Skip to content

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Aug 13, 2025

What does this PR do?

This implements extended collection of request data when an address with the action extended_data_collection triggers.

Motivation

Checklist

  • Unit tests.

Additional Notes

System Tests
Enabling System Tests

APPSEC-58758

@uurien uurien self-assigned this Aug 13, 2025
Copy link

github-actions bot commented Aug 13, 2025

Overall package size

Self size: 12.64 MB
Deduped: 112.86 MB
No deduping: 113.26 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.10.0 | 9.91 MB | 10.3 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.4 | 123.18 kB | 851.76 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.80%. Comparing base (4bb779b) to head (1c1ddbd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6275      +/-   ##
==========================================
+ Coverage   83.78%   83.80%   +0.01%     
==========================================
  Files         490      490              
  Lines       20632    20651      +19     
==========================================
+ Hits        17287    17306      +19     
  Misses       3345     3345              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Aug 13, 2025

Benchmarks

Benchmark execution time: 2025-10-08 15:37:15

Comparing candidate commit 1c1ddbd in PR branch ugaitz/extended-data-collection-v2 with baseline commit 4bb779b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1603 metrics, 67 unstable metrics.

@uurien uurien force-pushed the ugaitz/extended-data-collection-v2 branch from 882ca5f to c824e8b Compare August 13, 2025 15:04
@uurien uurien force-pushed the ugaitz/extended-data-collection-v2 branch from e409081 to fd542c6 Compare September 2, 2025 13:55
@uurien uurien force-pushed the ugaitz/extended-data-collection-v2 branch 2 times, most recently from 8d13157 to 7be3483 Compare September 22, 2025 10:07
@uurien uurien force-pushed the ugaitz/extended-data-collection-v2 branch 4 times, most recently from 50a1f15 to c4089ee Compare October 2, 2025 08:26
@uurien uurien marked this pull request as ready for review October 2, 2025 09:26
@uurien uurien requested review from a team as code owners October 2, 2025 09:26
@uurien uurien requested review from ida613 and removed request for a team October 2, 2025 09:26
@uurien uurien changed the title Extended request data collection via rules feat(appsec): Extended request data collection via rules Oct 2, 2025
@uurien uurien added the asm-waf label Oct 2, 2025
@uurien uurien changed the title feat(appsec): Extended request data collection via rules feat(aap): Extended request data collection via rules Oct 2, 2025
@bm1549 bm1549 requested review from BridgeAR and removed request for ida613 October 7, 2025 15:25
@bm1549 bm1549 requested a review from khanayan123 October 7, 2025 15:25
CarlesDD
CarlesDD previously approved these changes Oct 8, 2025
Copy link
Contributor

@CarlesDD CarlesDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

IlyasShabi
IlyasShabi previously approved these changes Oct 8, 2025
@uurien uurien enabled auto-merge (squash) October 8, 2025 14:52
@uurien uurien force-pushed the ugaitz/extended-data-collection-v2 branch from ab1a38d to 1c1ddbd Compare October 8, 2025 15:24
@uurien uurien merged commit a073145 into master Oct 9, 2025
736 checks passed
@uurien uurien deleted the ugaitz/extended-data-collection-v2 branch October 9, 2025 04:43
@dd-octo-sts dd-octo-sts bot mentioned this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants