Fix a bug with tryAddMessage being changed to async which causes messages to be dropped #6992
+72
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwilson6
changed the title
dwilson6
force-pushed
the
fix-az-service-bus-tryAddMessage-wrapper
branch
from
4dc8479 to
88fb032
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6992 +/- ##
==========================================
- Coverage 84.84% 84.83% -0.01%
==========================================
Files 517 517
Lines 22050 22050
==========================================
- Hits 18709 18707 -2
- Misses 3341 3343 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dwilson6
force-pushed
the
fix-az-service-bus-tryAddMessage-wrapper
branch
from
88fb032 to
02dee10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in the azure-service-bus instrumentation that breaks the createMessageBatch tryAddMessage method by changing it from a sync method that returns a boolean to an async method returning a promise.
Motivation
Ran into this bug which was causing some code to drop service bus messages when building batches due to returning a promise which is truthy even when the resolved promise would return false but the consuming code is synchronous.
Plugin Checklist
Additional Notes