Skip to content

Conversation

morrisonlevi
Copy link
Collaborator

Description

This adds support for DD_PROFILING_UPLOAD_COMPRESSION. It has 4 values:

  • off
  • on
  • lz4
  • zstd

"on" is the default, and aliases one of the other forms of compression. This is not expected to be used by end-users, but rather development and testing and benchmarking cost trade-offs. Specifically, we're testing out zstd.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

This adds support for DD_PROFILING_UPLOAD_COMPRESSION. It has 4 values:
 - off
 - on
 - lz4
 - zstd

"on" is the default, and aliases one of the other forms of compression.
This is not expected to be used by end-users, but rather development and
testing and benchmarking cost trade-offs.
@morrisonlevi morrisonlevi added the profiling Relates to the Continuous Profiler label May 19, 2025
@morrisonlevi morrisonlevi changed the title internal(prof): DD_PROFILING_UPLOAD_COMPRESSION internal(prof): configurable upload compression May 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.26%. Comparing base (0f03e1a) to head (4d78bf7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3259      +/-   ##
============================================
+ Coverage     76.35%   79.26%   +2.90%     
  Complexity     2948     2948              
============================================
  Files           145      118      -27     
  Lines         16082    11633    -4449     
  Branches       1110        0    -1110     
============================================
- Hits          12280     9221    -3059     
+ Misses         3225     2412     -813     
+ Partials        577        0     -577     
Flag Coverage Δ
appsec-extension ?
tracer-php 79.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f03e1a...4d78bf7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented May 19, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-05-21 16:40:22

Comparing candidate commit 4d78bf7 in PR branch PROF-11833-Support-DD_PROFILING_UPLOAD_COMPRESSION-in-PHP with baseline commit 0f03e1a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants