Skip to content

Conversation

Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Aug 12, 2025

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@Leiyks Leiyks force-pushed the leiyks/fix-ci-tests branch 2 times, most recently from 99ee2c1 to 0bcc803 Compare August 12, 2025 10:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.75%. Comparing base (8bef9c8) to head (b9078c6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3376      +/-   ##
==========================================
- Coverage   61.90%   61.75%   -0.15%     
==========================================
  Files         141      141              
  Lines       12481    12481              
  Branches     1630     1630              
==========================================
- Hits         7726     7708      -18     
- Misses       4033     4051      +18     
  Partials      722      722              

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bef9c8...b9078c6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Leiyks Leiyks force-pushed the leiyks/fix-ci-tests branch from 0bcc803 to 2334652 Compare August 12, 2025 12:59
@Leiyks Leiyks force-pushed the leiyks/fix-ci-tests branch 4 times, most recently from 3cacbbf to 4ee9185 Compare August 25, 2025 14:57
@pr-commenter
Copy link

pr-commenter bot commented Aug 25, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-09-01 15:23:16

Comparing candidate commit af9bc07 in PR branch leiyks/fix-ci-tests with baseline commit 8119103 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 190 metrics, 2 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+3.087µs; +4.713µs] or [+3.007%; +4.590%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-37.440µs; -25.960µs] or [-8.013%; -5.556%]

@Leiyks Leiyks force-pushed the leiyks/fix-ci-tests branch 6 times, most recently from e9711d3 to 854c3a5 Compare August 28, 2025 14:06
@bwoebi bwoebi changed the title test: add debug logs Fix some test failures / flakiness Sep 1, 2025
@Leiyks Leiyks marked this pull request as ready for review September 1, 2025 15:42
@Leiyks Leiyks requested a review from a team as a code owner September 1, 2025 15:42
Leiyks and others added 4 commits September 1, 2025 18:07
Signed-off-by: Alexandre Rulleau <[email protected]>
Signed-off-by: Alexandre Rulleau <[email protected]>
Composer version 1 has been turned off, so we no longer have to care.

Signed-off-by: Bob Weinand <[email protected]>
@Leiyks Leiyks force-pushed the leiyks/fix-ci-tests branch 2 times, most recently from 4ff3fde to 8b8135d Compare September 2, 2025 11:29
Signed-off-by: Bob Weinand <[email protected]>
@Leiyks Leiyks force-pushed the leiyks/fix-ci-tests branch from 8b8135d to b9078c6 Compare September 2, 2025 14:50
@bwoebi bwoebi merged commit 3259252 into master Sep 2, 2025
1851 of 1871 checks passed
@bwoebi bwoebi deleted the leiyks/fix-ci-tests branch September 2, 2025 17:55
@github-actions github-actions bot added this to the 1.13.0 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants