Skip to content

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Aug 13, 2025

  • Using static for integrations (avoiding carrying an Integration instance around).
  • static Closures
  • Simplify sandboxed calls, reduce them to minimum overhead
  • Only allocate new runtime cache objects when actually needed

@bwoebi bwoebi force-pushed the bob/static-integrations branch from a4e63a4 to 66951c5 Compare August 13, 2025 13:22
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.74%. Comparing base (e4f6598) to head (a78c4ee).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
- Coverage   61.87%   61.74%   -0.13%     
==========================================
  Files         141      141              
  Lines       12481    12481              
  Branches     1630     1630              
==========================================
- Hits         7722     7706      -16     
- Misses       4038     4054      +16     
  Partials      721      721              

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f6598...a78c4ee. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Aug 13, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-09-18 17:45:37

Comparing candidate commit a78c4ee in PR branch bob/static-integrations with baseline commit e4f6598 in branch master.

Found 11 performance improvements and 2 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.880µs; -0.920µs] or [-13.526%; -6.618%]

scenario:ContextPropagationBench/benchExtractHeaders64Bit

  • 🟩 execution_time [-93.400ns; -30.600ns] or [-7.575%; -2.482%]

scenario:HookBench/benchHookOverheadInstallHookOnFunction

  • 🟩 execution_time [-116.111µs; -102.024µs] or [-19.750%; -17.354%]

scenario:HookBench/benchHookOverheadInstallHookOnFunction-opcache

  • 🟩 execution_time [-89.726µs; -73.826µs] or [-16.268%; -13.385%]

scenario:HookBench/benchHookOverheadInstallHookOnMethod

  • 🟩 execution_time [-98.362µs; -83.384µs] or [-16.495%; -13.984%]

scenario:HookBench/benchHookOverheadInstallHookOnMethod-opcache

  • 🟩 execution_time [-89.046µs; -67.458µs] or [-16.035%; -12.147%]

scenario:LogsInjectionBench/benchLogsInfoInjection

  • 🟩 execution_time [-680.155ns; -490.845ns] or [-9.384%; -6.772%]

scenario:LogsInjectionBench/benchLogsInfoInjection-opcache

  • 🟩 execution_time [-709.753ns; -340.647ns] or [-7.483%; -3.591%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-7.943µs; -7.077µs] or [-7.259%; -6.467%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-8.603µs; -7.517µs] or [-7.724%; -6.749%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 mem_peak [+209.344KB; +209.344KB] or [+4.616%; +4.616%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟥 mem_peak [+207.536KB; +207.536KB] or [+9.464%; +9.464%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-64.122µs; -53.578µs] or [-13.582%; -11.349%]

@bwoebi bwoebi force-pushed the bob/static-integrations branch from b5df6e7 to c81d074 Compare August 14, 2025 16:49
@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-09-18 16:54:28

Comparing candidate commit a78c4ee in PR branch bob/static-integrations with baseline commit e4f6598 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@bwoebi bwoebi force-pushed the bob/static-integrations branch 13 times, most recently from 6005add to 350c05d Compare August 21, 2025 14:11
@bwoebi bwoebi force-pushed the bob/static-integrations branch 7 times, most recently from 229d1fa to 908d13c Compare September 1, 2025 17:20
@bwoebi bwoebi force-pushed the bob/static-integrations branch 2 times, most recently from ac3d79c to eb180fb Compare September 4, 2025 16:48
Signed-off-by: Bob Weinand <[email protected]>

# Conflicts:
#	src/DDTrace/Integrations/Kafka/KafkaIntegration.php
(^[\t ]++)(.*)(?<!static |_)\b(function\s*\(([^$\n]++|\n|\$(?!this))+?^\1})
by
$1$2static $3
@bwoebi bwoebi force-pushed the bob/static-integrations branch from eb180fb to 4f9acaf Compare September 17, 2025 18:10
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi marked this pull request as ready for review September 19, 2025 11:13
@bwoebi bwoebi requested review from a team as code owners September 19, 2025 11:13
@bwoebi bwoebi merged commit 4c233be into master Sep 19, 2025
1859 of 1872 checks passed
@bwoebi bwoebi deleted the bob/static-integrations branch September 19, 2025 13:43
@github-actions github-actions bot added this to the 1.13.0 milestone Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants