Skip to content

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 17, 2025

Make sure that dogstatsd_endpoint and ddtrace_endpoint are always freed together and the existence governed by ddtrace_endpoint.

Follow-up to #3407.

Make sure that dogstatsd_endpoint and ddtrace_endpoint are always freed together and the existence governed by ddtrace_endpoint.

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested a review from a team as a code owner October 17, 2025 16:20
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.75%. Comparing base (9298487) to head (525d73a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3451      +/-   ##
==========================================
- Coverage   61.89%   61.75%   -0.14%     
==========================================
  Files         141      141              
  Lines       12501    12501              
  Branches     1633     1633              
==========================================
- Hits         7737     7720      -17     
- Misses       4042     4058      +16     
- Partials      722      723       +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9298487...525d73a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-10-17 17:25:13

Comparing candidate commit 525d73a in PR branch bob/fix-sidecar-vars with baseline commit 9298487 in branch master.

Found 1 performance improvements and 7 performance regressions! Performance is the same for 186 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟥 execution_time [+442.675ns; +1357.325ns] or [+4.176%; +12.805%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+2.253µs; +3.307µs] or [+2.101%; +3.085%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+93.172ns; +133.228ns] or [+8.040%; +11.496%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+65.561ns; +124.239ns] or [+5.509%; +10.440%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+109.139ns; +165.061ns] or [+9.357%; +14.151%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+66.592ns; +114.408ns] or [+5.671%; +9.743%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 mem_peak [+1.696MB; +1.702MB] or [+4.103%; +4.118%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-28.887µs; -14.813µs] or [-6.542%; -3.355%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants