-
Notifications
You must be signed in to change notification settings - Fork 449
chore(django): migrate template render wrappers to WrappingContext #14069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 282 ± 4 ms. The average import time from base is: 285 ± 3 ms. The import time difference between this PR and base is: -2.5 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Co-authored-by: Gabriele N. Tornetta <[email protected]>
…ded.event' into LANGPLAT-642/django-bytecode-templates
Performance SLOsCandidate: LANGPLAT-642/django-bytecode-templates (cc604ac) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
Depends on #14098
We will work to update the Django integration to use new wrapping patterns. Overall this should have a performance impact, but only doing template render is not having enough of an impact to call this a performance improvement for Django.
The only change to tests needed were the ones asserting that
Template.render
was wrapped, otherwise all existing tests are passing.Checklist
Reviewer Checklist