Skip to content

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Jul 25, 2025

What does this PR do? What is the motivation?

  • Adds a new Cost Allocation landing page
  • Reorganizes the Container Cost Allocation section to accommodate new BigQuery page and existing providers
  • Adds a new BigQuery Cost Allocation page

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Jul 25, 2025
@rtrieu rtrieu requested review from a team as code owners July 25, 2025 20:08
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jul 25, 2025
Copy link
Contributor

github-actions bot commented Jul 25, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Member

@elihschiff elihschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about the ordering and flow feels off to me

What do about the Allocating costs section starting with

  1. Compute allocation
  2. Compute
  3. Query-level tag extraction
  4. the untitled text under Allocating costs
  5. Understanding idle costs
  6. Storage
    Not sure if I missed anything

Great work, this is really good. I have a number of small comments but overall this is really great work and hits all the key points I would have wanted to know about


{{< partial name="whats-next/whats-next.html" >}}

[1]: https://app.datadoghq.com/dashboard/ecm-es8-agw/bigquery-allocation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure we do not merge this PR until this dashboard is pushed to production and the link is corrected to the version that works in everyone's account. Otherwise this is just a link to the internal test version of the dashboard


Datadog Cloud Cost Management (CCM) automatically allocates the costs of your Google BigQuery resources to individual queries and workloads. Use cost metrics enriched with tags from queries, projects, and reservations to visualize BigQuery workload costs in the context of your entire cloud bill.

## Resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this section is adding? Maybe it can be combined with the overview if there is anything important, otherwise I feel like the rest of the doc covers this.
just my opinion, feel free to ignore me

Comment on lines 104 to 105
| Active | Includes any table or table partition that has been modified in the last 90 days |
| Long-term | Includes any table or table partition that has not been modified for 90 consecutive days. The price of storage for that table automatically drops by approximately 50%. There is no difference in performance, durability, or availability between active and long-term storage |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tag key is this? It is good to in general try and provide a key+value so a user can find it themselves

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its the google_usage_type tag! I will add that and also add the allocated_spend_type tag for usage and cluster_idle above!

Copy link
Member

@elihschiff elihschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this is much improved

| Query-Level Cost Attribution | BigQuery monitoring enabled |
| Reservation Cost Allocation | BigQuery reservations configured |

1. Configure the Google Cloud Cost Management integration on the [Cloud Cost Setup page][2].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link gives me a 404 error when I click it

1. Configure the Google Cloud Cost Management integration on the [Cloud Cost Setup page][2].
2. Enable BigQuery monitoring in your Google Cloud project.
[**Enable BigQuery monitoring here**][4]
3. For reservation cost allocation, configure BigQuery reservations in your project. [**Learn about BigQuery reservations.**][7]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need this one to be honest. It is not really setup. Either they have it enabled and we support allocation or they dont and that is also fine. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense. It's mentioned in the pricing description that setting up reservations is more cost-efficient so it is up to the customer if they want to set it up -> see allocated costs for it. Ty for the suggestion

Copy link
Member

@elihschiff elihschiff Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok maybe lets leave it then but mark it as optional and mention that it is typically more price efficient with a link for proof?

CCM customers do like to save money after all

Comment on lines 65 to 66
| `allocated_spend_type`: Usage | Cost of query execution based on bytes processed (on-demand) or slot consumption (reservation) |
| `allocated_spend_type`: Cluster_idle | Cost of reserved slots allocated within a project but not utilized by queries|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `allocated_spend_type`: Usage | Cost of query execution based on bytes processed (on-demand) or slot consumption (reservation) |
| `allocated_spend_type`: Cluster_idle | Cost of reserved slots allocated within a project but not utilized by queries|
| `allocated_spend_type:usage` | Cost of query execution based on bytes processed (on-demand) or slot consumption (reservation) |
| `allocated_spend_type:cluster_idle` | Cost of reserved slots allocated within a project but not utilized by queries|

I think this is a bit cleaner and easier for a user to copy into their query editor, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sg i'll change it to this for the storage types too!

@joepeeples
Copy link
Contributor

joepeeples commented Aug 5, 2025

Opened DOCS-11735 to assign a Docs writer and follow up with editorial review.

@joepeeples joepeeples added the editorial review Waiting on a more in-depth review label Aug 5, 2025
@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 15, 2025
Copy link
Collaborator

@bgdeutsch bgdeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rtrieu rtrieu merged commit 94706ee into master Aug 19, 2025
16 checks passed
@rtrieu rtrieu deleted the rtrieu/kaylawan2/docs-11631-bigquery-cost-allocation branch August 19, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants