-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[docseng-99] [DO NOT MERGE] removes websites-sources go module #31175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bgdeutsch
wants to merge
10
commits into
master
Choose a base branch
from
brian.deutsch/docseng-99-s3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
ℹ️ Documentation Team ReviewNo documentation team review is required for this pull request. |
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
@make server | ||
|
||
# Skip downloading any dependencies and run the site (hugo needs at the least node) | ||
start-no-pre-build: node_modules ## Build and run docs excluding external content. | ||
@make setup-build-scripts | ||
@make update_websites_sources_module | ||
@make websites_sources_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we also want to get data from s3 on make start
and start-preserve-build
too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
websites-sources
data from s3 at build timemotivation:
Merge instructions
this is blocked on docs-ci pr first
Additional notes
Preview
preview site here (note this could get out of date):
https://docs-staging.datadoghq.com/brian.deutsch/docseng-99-s3
we need to check pages/data sourced from websites-sources and ensure it is building and rendering correctly.
examples:
integrations: https://docs-staging.datadoghq.com/brian.deutsch/docseng-99-s3/integrations
rbac permissions: https://docs-staging.datadoghq.com/brian.deutsch/docseng-99-s3/account_management/rbac/permissions
cloud siem content packs: https://docs-staging.datadoghq.com/brian.deutsch/docseng-99-s3/security/cloud_siem/content_packs/#overview
iac rules: https://docs-staging.datadoghq.com/brian.deutsch/docseng-99-s3/security/code_security/iac_security/iac_rules/
semantic core metrics mapping: https://docs-staging.datadoghq.com/brian.deutsch/docseng-99-s3/opentelemetry/mapping/metrics_mapping/
Local Testing
going forward docs should be able to review integrations that are in the APW review bucket at the time of building locally. this would be the preferred method of confirming upstream changes.
be sure to run
make clean-all
first to ensure no artifacts are leftover from previous buildspull this branch locally:
make start-no-pre-build
, andmake start
build successfully and render pages properly based on sourced data.yarn start
works (THERE IS A KNOWN ISSUE HERE)make start-no-pre-build
worksmake start
works