Skip to content

Conversation

@tbavelier
Copy link
Member

@tbavelier tbavelier commented Oct 22, 2025

What this PR does / why we need it:

  • Do not mount kernel headers directories from Talos nodes, as it uses some read-only mounts, preventing the DS from being scheduled since the volume can't be created on the host
    • system-probe should use instead debugfs (if available on the node) or mount tracefs manually
    • Moreover, we have btf files present on Talos Linux nodes, so we can use the default CO-RE instead of relying on runtime compilation
╰─❯ talosctl -n 10.1.10.253 ls /sys/kernel/btf
NODE          NAME
10.1.10.253   .
10.1.10.253   ena
10.1.10.253   nvme
10.1.10.253   vmlinux

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@tbavelier tbavelier requested a review from a team as a code owner October 22, 2025 09:33
@tbavelier tbavelier added chart/datadog This issue or pull request is related to the datadog chart datadog/patch-version Patch version bump for datadog chart labels Oct 22, 2025
- bump version for datadog to 3.139.1 (patch-version)
- update changelog for datadog with version 3.139.1
- update readme for datadog
- update readme for datadog
@tbavelier tbavelier changed the title Tbavelier/fix system probe talos Fix system-probe on Talos Linux Oct 22, 2025
- update readme for datadog
@tbavelier
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 24, 2025

View all feedbacks in Devflow UI.

2025-10-24 13:28:16 UTC ℹ️ Start processing command /merge


2025-10-24 13:28:22 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 60m (p90).


2025-10-24 14:16:14 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • some status checks are failing:
    • dd-gitlab/e2e: [e2e_autopilot, 7-rc]
  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2105/merge: 405 Required status check "pr-validated" is expected. [] (Request ID: 885A:10E02B:BE8DC8:32E62F0:68FB8A25)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-79df4f7b67-nqsh5@): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2105/merge: 405 Required status check "pr-validated" is expected. [] (Request ID: 885A:10E02B:BE8DC8:32E62F0:68FB8A25) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/helm-charts/pulls/2105/merge: 405 Required status check "pr-validated" is expected. [] (type: ErrorResponse, retryable: true)

@tbavelier tbavelier merged commit 7eff8f4 into main Oct 24, 2025
37 checks passed
@tbavelier tbavelier deleted the tbavelier/fix-system-probe-talos branch October 24, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart/datadog This issue or pull request is related to the datadog chart datadog/patch-version Patch version bump for datadog chart mergequeue-status: error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants