Add more logs recommendations and best practices #21047
Open
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
stzou
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
Looks good to me, but we'd still need to wait on the fluentbit PR(correcting the task_arn to use full format) to be merged before we merge this PR as the enrichment based off of source:ecs will not take place without the fluentbit change.
maycmlee
previously approved these changes
Aug 13, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
Co-authored-by: May Lee <[email protected]>
temporal-github-worker-1
bot
dismissed
maycmlee’s stale review
Review from maycmlee is dismissed. Related teams and files:
- documentation
- ecs_fargate/README.md
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
JLineaweaver
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add more recommendations for Fluentbit (the best way to send logs for ECS Fargate)
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged