-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[SAASINT-4564] DDS: ZeroFox Cloud Platform: Crawler Integration v1.0.0 #21118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[SAASINT-4564] DDS: ZeroFox Cloud Platform: Crawler Integration v1.0.0 #21118
Conversation
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but non-blocking for this PR
- Username | ||
- Password | ||
|
||
Note: User account that is associated with a ZeroFox customer enterprise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm—should the note indicate that the username and password must come from an account that's associated with a ZeroFox customer enterprise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the note indicate that the username and password must come from an account that's associated with a ZeroFox customer enterprise.
1. Add your Username and Password. | ||
| Parameters | Description | | ||
| -------- | ---------------------------------------------- | | ||
| Username | The Username of your ZeroFox Platform account. | | ||
| Password | The Password of your ZeroFox Platform account. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the table and consolidated the parameter descriptions into a single sentence to reduce redundancy.
1. Add your Username and Password. | |
| Parameters | Description | | |
| -------- | ---------------------------------------------- | | |
| Username | The Username of your ZeroFox Platform account. | | |
| Password | The Password of your ZeroFox Platform account. | | |
1. Add the Username and Password of your ZeroFox Platform account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per discussion with our PM @dpoint01, We keep this format consistent across all our integrations.
CC: @torosmassa
| -------- | ---------------------------------------------- | | ||
| Username | The Username of your ZeroFox Platform account. | | ||
| Password | The Password of your ZeroFox Platform account. | | ||
2. Click the Save button to save your settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Click the Save button to save your settings. | |
2. Click **Save**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in above comment(link), We keep this format consistent across all our integrations
Review from estherk15 is dismissed. Related teams and files:
- documentation
- zerofox_cloud_platform/assets/dashboards/zerofox_cloud_platform_alert_insights.json
- zerofox_cloud_platform/manifest.json
What does this PR do?
This is a initial release PR of ZeroFox Cloud Platform integration including all the required assets.
Integration Logo Source: https://brand.zerofox.com/logo
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged