Skip to content

Conversation

shubhamvekariya-crest
Copy link
Contributor

@shubhamvekariya-crest shubhamvekariya-crest commented Aug 20, 2025

What does this PR do?

This is a initial release PR of ZeroFox Cloud Platform integration including all the required assets.

Integration Logo Source: https://brand.zerofox.com/logo

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@shubhamvekariya-crest shubhamvekariya-crest changed the title DDS: ZeroFox Cloud Platform: Crawler Integration v1.0.0 [SAASINT-4564] DDS: ZeroFox Cloud Platform: Crawler Integration v1.0.0 Aug 22, 2025
@shubhamvekariya-crest shubhamvekariya-crest marked this pull request as ready for review August 22, 2025 12:01
@shubhamvekariya-crest shubhamvekariya-crest requested review from a team as code owners August 22, 2025 12:01
estherk15
estherk15 previously approved these changes Aug 22, 2025
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but non-blocking for this PR

- Username
- Password

Note: User account that is associated with a ZeroFox customer enterprise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm—should the note indicate that the username and password must come from an account that's associated with a ZeroFox customer enterprise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the note indicate that the username and password must come from an account that's associated with a ZeroFox customer enterprise.

Comment on lines +21 to +25
1. Add your Username and Password.
| Parameters | Description |
| -------- | ---------------------------------------------- |
| Username | The Username of your ZeroFox Platform account. |
| Password | The Password of your ZeroFox Platform account. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the table and consolidated the parameter descriptions into a single sentence to reduce redundancy.

Suggested change
1. Add your Username and Password.
| Parameters | Description |
| -------- | ---------------------------------------------- |
| Username | The Username of your ZeroFox Platform account. |
| Password | The Password of your ZeroFox Platform account. |
1. Add the Username and Password of your ZeroFox Platform account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion with our PM @dpoint01, We keep this format consistent across all our integrations.
CC: @torosmassa

| -------- | ---------------------------------------------- |
| Username | The Username of your ZeroFox Platform account. |
| Password | The Password of your ZeroFox Platform account. |
2. Click the Save button to save your settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Click the Save button to save your settings.
2. Click **Save**.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in above comment(link), We keep this format consistent across all our integrations

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed estherk15’s stale review August 26, 2025 09:31

Review from estherk15 is dismissed. Related teams and files:

  • documentation
    • zerofox_cloud_platform/assets/dashboards/zerofox_cloud_platform_alert_insights.json
    • zerofox_cloud_platform/manifest.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants