Skip to content

Conversation

@AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Aug 22, 2025

What does this PR do?

This PR creates the utils.hatch module that define hatch command wrappers to simplify the interaction with hatch. This module is used to simplify the environment selection of ddev env test.

Motivation

As part of the review of #21119 we wanted to simplify the logic that gets environments from hatch and decided to extract the logic to is own set of wrapper methods. The intention is that we move raw command executions to the wrappers, increasing the encapsulation of hatch usage.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Aug 22, 2025
@AAraKKe AAraKKe force-pushed the aarakke/refactor-hatch-commands-in-ddev-env-test branch from 08d20b0 to f1eee0a Compare August 22, 2025 13:56
@AAraKKe AAraKKe changed the title Remove unused test file Create hatch command wrappers Aug 22, 2025
@AAraKKe AAraKKe changed the base branch from master to aarakke/fix-e2e-selection-for-specific-environment August 22, 2025 13:58
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 97.43590% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.84%. Comparing base (0c18c2a) to head (0b5962b).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from aarakke/fix-e2e-selection-for-specific-environment to master August 22, 2025 15:01
@AAraKKe AAraKKe force-pushed the aarakke/refactor-hatch-commands-in-ddev-env-test branch from bc84564 to 0b5962b Compare August 22, 2025 15:23
@AAraKKe AAraKKe marked this pull request as ready for review August 22, 2025 15:34
@AAraKKe AAraKKe requested a review from a team as a code owner August 22, 2025 15:34
Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Awesome! LGTM

@AAraKKe AAraKKe added this pull request to the merge queue Aug 25, 2025
Merged via the queue into master with commit 7286fd7 Aug 25, 2025
327 of 328 checks passed
@AAraKKe AAraKKe deleted the aarakke/refactor-hatch-commands-in-ddev-env-test branch August 25, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants