-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Validate that dependencies are in the correct section in pyproject.toml #21898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Validate that dependencies are in the correct section in pyproject.toml #21898
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
| assert "Third-party" in result.output | ||
| assert "base check dependency" in result.output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you assert the whole error message, maybe with a regex, so we know exactly what error we are expecting?
|
Sarah asked over slack to check integrations-extras and marketplace to make sure it works there. I checked both and they do have quite a few errors. Not sure if we have to fix all of these since they are in the extras and marketplace repos but I will check. Posting an example below from each repo Extras:
Marketplace:
|
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
|
Hi @ddog-nasirthomas thanks for checking those repos! And great that the new validation has already caught some errors! Can you fix those now so once we merge and release this, those repos aren't failing the validation? |
|
Extras and Marketplace PR got approved. Currently in a code freeze but I will follow up on this PR once they get merged after |
What does this PR do?
Update
ddev validate depto validate if third-party dependencies are listed in project.dependenciesMotivation
AI-5661
Third-party libraries go in the [project.optional-dependencies] section instead of [project].
If a dependency is misplaced, CI won’t catch it at the PR stage. As a result, it could be merged into master, leaving it in an unbuildable state.
This adds validation to detect this mistake
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged