Skip to content

Modernize vSphere dashboards with enhanced filtering and query format #21910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Modernize vSphere dashboards with enhanced filtering and query format #21910

wants to merge 4 commits into from

Conversation

@mahipdeora25
Copy link
Contributor

@mahipdeora25 mahipdeora25 commented Nov 18, 2025

  • Update dashboard query format from legacy to modern formula-based queries
  • Add comprehensive template variables (vcenter_server, vcenter_datacenter, vsphere_host, VM)
  • Enhance filtering capabilities across all widgets with new template variables
  • Add vSAN cluster monitoring widgets to overview dashboard
  • Standardize dashboard file naming (fix hyphen inconsistency)
  • Update manifest.json to reflect new dashboard paths

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mahipdeora25
Modernize vSphere dashboards with enhanced filtering and query format
ad0d88a 
- Update dashboard query format from legacy to modern formula-based queries
- Add comprehensive template variables (vcenter_server, vcenter_datacenter, vsphere_host, VM)
- Enhance filtering capabilities across all widgets with new template variables
- Add vSAN cluster monitoring widgets to overview dashboard
- Standardize dashboard file naming (fix hyphen inconsistency)
- Update manifest.json to reflect new dashboard paths
@mahipdeora25 mahipdeora25 requested review from a team as code owners November 18, 2025 19:17
@github-actions
Copy link

github-actions bot commented Nov 18, 2025 •
edited
Loading

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

joepeeples
joepeeples previously approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged a couple possible typos, otherwise LGTM, thanks!

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed joepeeples’s stale review November 18, 2025 20:01

Review from joepeeples is dismissed. Related teams and files:

  • documentation
    • vsphere/assets/dashboards/vmware_vsphere_-_overview.json
sarah-witt
sarah-witt reviewed Nov 24, 2025
View reviewed changes
vsphere/manifest.json Outdated
"VMware vSphere TKG - Overview": "assets/dashboards/vmware_vsphere_tkg_-_overview.json",
"VMware vSphere - Property Metrics": "assets/dashboards/vmware_vsphere-_property_metrics.json"
"VMware vSphere - Property Metrics": "assets/dashboards/vmware_vsphere_-_property_metrics.json",
"VMware vSphere - Overview": "assets/dashboards/vmware_vsphere_-_overview.json"
Copy link
Contributor

@sarah-witt sarah-witt Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names have no impact on the display name (you will need to update the title in the json file), but changing them will create "new" dashboards. Can you revert the changes to the names here?

Also, the file name also does not change anything about the dashboard, but changing it makes the PR harder to review. Would you be ok with changing that back as well?

Copy link
Contributor Author

@mahipdeora25 mahipdeora25 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah-witt please see latest changes

@mahipdeora25
Update vsphere dashboard filenames and manifest.json
b5781f4 
- Rename vmware_vsphere_-_overview.json to vsphere_overview.json
- Rename vmware_vsphere_-_property_metrics.json to vmware_vsphere-_property_metrics.json (fix hyphen)
- Update manifest.json to reflect new dashboard paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah-witt sarah-witt sarah-witt left review comments

@joepeeples joepeeples joepeeples left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

docs/review-requested documentation ecosystems/review-requested integration/vsphere product/review-requested team/agent-integrations team/documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahipdeora25 @sarah-witt @joepeeples