-
Notifications
You must be signed in to change notification settings - Fork 8
Add ThreadFilterBenchmark #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔧 Report generated by pr-comment-scanbuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's start with this.
My only objection is that this is, technically, not a microbenchmark. The measured code does a lot of things so it will be highly susceptible to noise.
I agree. It is actually a stress test - name is a bit misleading. |
What does this PR do?:
This benchmark is extracted from @r1viollet 's PR#209
Motivation:
I would like to merge this benchmark separately, so we can use it to experiment various ideas for improving thread filter.
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!