Skip to content

Fix gradle build task #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Fix gradle build task #263

wants to merge 9 commits into from

Conversation

zhengyu123
Copy link
Contributor

What does this PR do?:
Fix ./gradlew build of java-profiler

Motivation:
Current ./gradlew build of java-profiler repository results following errors:

> Task :ddprof-lib:benchmarks:compileDebugMacosAarch64Cpp FAILED
In file included from /Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/benchmarks/src/unwindFailuresBenchmark.cpp:2:
In file included from /Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/src/main/cpp/unwindStats.h:5:
In file included from /Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/src/main/cpp/spinLock.h:20:
/Users/zhengyu.gu/go/src/github.com/DataDog/java-profiler/ddprof-lib/src/main/cpp/arch_dd.h:4:10: fatal error: 'arch.h' file not found
    4 | #include "arch.h"
      |          ^~~~~~~~
1 error generated.

This patch fixes above problem.

Additional Notes:

How to test the change?:
Run ./gradlew build from java-profiler repo, build should succeed without error.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

@zhengyu123 zhengyu123 marked this pull request as draft August 18, 2025 19:59
@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 18, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 19, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 19, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 19, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 20, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 20, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

@dd-octo-sts
Copy link

dd-octo-sts bot commented Aug 20, 2025

CppCheck Report

Errors (2)

Warnings (8)

Style Violations (299)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant