Skip to content

Conversation

@estringana
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@estringana estringana force-pushed the estringana/enable-scanner-tests-php branch from 9c815fa to 2c0672b Compare July 3, 2025 15:59
@estringana estringana changed the base branch from main to estringana/point-to-s3-php-artifacts July 3, 2025 15:59
@estringana estringana force-pushed the estringana/point-to-s3-php-artifacts branch 4 times, most recently from 5262eee to 66a5d20 Compare July 14, 2025 13:26
@estringana estringana force-pushed the estringana/enable-scanner-tests-php branch from 2c0672b to 4a7ca07 Compare July 14, 2025 14:08
@estringana estringana changed the title Enable scaner tests for PHP [php] Enable scaner tests for PHP Jul 14, 2025
Base automatically changed from estringana/point-to-s3-php-artifacts to main July 14, 2025 22:19
@estringana estringana force-pushed the estringana/enable-scanner-tests-php branch from a5c6849 to e2eb058 Compare July 15, 2025 07:19
@estringana estringana marked this pull request as ready for review July 15, 2025 07:45
@estringana estringana requested review from a team as code owners July 15, 2025 07:45
@estringana estringana enabled auto-merge (squash) July 15, 2025 09:00
@estringana estringana merged commit 4632ebe into main Jul 15, 2025
116 checks passed
@estringana estringana deleted the estringana/enable-scanner-tests-php branch July 15, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants