Skip to content

Conversation

@iamluc
Copy link
Contributor

@iamluc iamluc commented Jun 18, 2025

Motivation

Test PHP implementation: DataDog/dd-trace-php#3301

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@iamluc iamluc force-pushed the luc/php_docker_ssi_instrumentation_source branch from 33a8cb9 to 79021b9 Compare August 29, 2025 14:19
@iamluc iamluc marked this pull request as ready for review August 29, 2025 14:53
@iamluc iamluc requested review from a team as code owners August 29, 2025 14:53
@iamluc iamluc requested a review from mabdinur August 29, 2025 14:53
@iamluc
Copy link
Contributor Author

iamluc commented Aug 29, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 29, 2025

View all feedbacks in Devflow UI.

2025-08-29 15:16:32 UTC ℹ️ Start processing command /merge


2025-08-29 15:16:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 3m (p90).


2025-08-29 15:39:01 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 56aba10 into main Aug 29, 2025
579 checks passed
@dd-mergequeue dd-mergequeue bot deleted the luc/php_docker_ssi_instrumentation_source branch August 29, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants