Skip to content

[java] Enable schema extraction tests in Java #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 7, 2025
Merged

[java] Enable schema extraction tests in Java #4830

merged 6 commits into from
Jul 7, 2025

Conversation

@manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Jun 24, 2025 •
edited
Loading

Motivation

Response body extraction has already been implemented in Java, the PR enables those tests.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/enable-schema-extraction-java branch from ca89031 to 3d5a579 Compare June 25, 2025 07:21
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/enable-schema-extraction-java branch from 2706290 to 281aa09 Compare July 3, 2025 08:00
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review July 3, 2025 08:00
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from a team as code owners July 3, 2025 08:00
cbeauchesne
cbeauchesne requested changes Jul 3, 2025
View reviewed changes
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/enable-schema-extraction-java branch from 281aa09 to 2ec163b Compare July 4, 2025 07:24
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/enable-schema-extraction-java branch from e066b82 to d80c313 Compare July 7, 2025 07:22
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit c129434 into main Jul 7, 2025
81 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/enable-schema-extraction-java branch July 7, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandro996 jandro996 jandro996 approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog is a code owner automatically assigned from DataDog/asm-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@manuel-alvarez-alvarez @jandro996 @cbeauchesne @sezen-datadog