Skip to content

Conversation

robertomonteromiguel
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel commented Jun 30, 2025

Motivation

Original PR: #4854
Cursor iterations:

- Iteration 1:

Validate the auto activation of Appsec (AAP) using AWS SSI in different environments.
I want to create 3 aws ssi scenarios, that are very similar to the aws ssi profiling scenario, but in this case instead of adding the evn variable "DD_PROFILING_ENABLED=auto",we will add the variable
"DD_APPSEC_ENABLED=true". The new appsec scenarios are:
SIMPLE_AUTO_INJECTION_APPSEC (feature 478)
HOST_AUTO_INJECTION_INSTALL_SCRIPT_APPSEC (feature 479)
CONTAINER_AUTO_INJECTION_INSTALL_SCRIPT_APPSEC (feature 480)

The appsec test is verifying that the received span contain the metric _dd.appsec.enabled set to 1 and the meta tag appsec.event set to true.

- Iteration 2:

but the method "_test_install" of the AutoInjectBaseTest class, doesn't accept the parameter appsec=true and it is not executing the validation of : Metric _dd.appsec.enabled set to 1 and Meta tag appsec.event set to true

- Iteration 3:

In the method _validate_appsec_trace you are validating correctly the metrics for appsec, but you are not validating the meta appsec event. This is the validation:
meta["appsec.event"] == true

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/curso_demo_pr branch July 11, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant