Skip to content

Conversation

@jandro996
Copy link
Member

Motivation

Enable TestSamplingByRouteMethodCount test for java

Changes

Endpoints and enable test in java.yml

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@jandro996 jandro996 marked this pull request as ready for review July 4, 2025 11:25
@jandro996 jandro996 requested review from a team as code owners July 4, 2025 11:25
java.security.MessageDigest.getInstance("SHA1").digest("hash12".getBytes(java.nio.charset.StandardCharsets.UTF_8))
java.security.MessageDigest.getInstance("SHA1").digest("hash13".getBytes(java.nio.charset.StandardCharsets.UTF_8))
java.security.MessageDigest.getInstance("SHA1").digest("hash14".getBytes(java.nio.charset.StandardCharsets.UTF_8))
java.security.MessageDigest.getInstance("SHA1").digest("hash15".getBytes(java.nio.charset.StandardCharsets.UTF_8))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hand counting 😭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 we need trigger the vulns in that way to avoid deduplication

chain.path("iast/sampling-by-route-method-count/:id", ctx -> {
ctx.byMethod(m -> m
.get(ctxGet -> {
// lógica para GET
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I see spanglish 😆

}
});

// Register resources

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! leftovers thanks!

@jandro996 jandro996 merged commit 64539d1 into main Jul 7, 2025
563 checks passed
@jandro996 jandro996 deleted the alejandro.gonzalez/enable-java-new-iast-detection branch July 7, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants