[CONTP-921] Configure read-only root filesystem for Datadog Agent #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabedos
reviewed
Nov 6, 2025
| s.NoError(err, "Failed to parse container definitions") | ||
| s.Equal(6, len(containers), "Expected 6 containers in the task definition") | ||
| s.Equal(7, len(containers), "Expected 6 containers in the task definition") | ||
|
|
Collaborator
There was a problem hiding this comment.
Can we add an assertion here that confirms the presence of the relevant volumes and volumeMounts for ROFS?
gabedos
reviewed
Nov 6, 2025
modules/ecs_fargate/datadog.tf
Outdated
| } | ||
| ], | ||
|
|
||
| dependsOn = local.rofs_agent_depends_on, |
Collaborator
There was a problem hiding this comment.
We already have a dependsOn parameter defined 3 lines below. There likely is some overwriting going on? Can we merge local.rofs_agent_depends_on with local.log_router_dependency
Contributor
Author
There was a problem hiding this comment.
Ah didn't see that. Thanks for catching!
Mathew-Estafanous
force-pushed
the
mathew.estafanous/rofs
branch
2 times, most recently
from
8f3871b to
679a1cc
Compare
Mathew-Estafanous
force-pushed
the
mathew.estafanous/rofs
branch
from
679a1cc to
06b41ef
Compare
gabedos
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
readOnlyRootFilesystemsupport for thedatadog-agentsidecar container and added an init container, namedinit-volume, that copies /etc/datadog-agent config files to a writeable volume. This named volume is then attached to datadog-agent sidecar as a writable volumeMotivation
Read-only root filesystems (ROFS) have become a standard security measure when running containerized apps and it is important that Datadog keeps up with the latest security measures. Supporting ROFS out-of-the-box ensures customers deploying the Agent with the 'ecs-datadog' terraform module continue to keep up with security standards without any extra work from them.
Describe how you validated your changes
Additional Notes