-
Notifications
You must be signed in to change notification settings - Fork 18
rename tables in djqs #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename tables in djqs #1145
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
shangyian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does make sense, but I can see that some assumptions made by the query service will be different. One original assumption was that it would call the core API to post changes rather than touching the metadata db, but it can now just make changes in the metadata database directly.
Also this change will need to handle multi-tenancy as well, related to #1122, since there would need to be a separate query service attached to each tenant of the core service.
shangyian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll want to run make check (linters) and make test. Some of the tests are failing due to the naming change from Catalog -> QSCatalog
|
Thanks @sadath-12! I'll review this soon and also pull it locally to try it out.
I'm hoping we can stick with this assumption and avoid having one of the services directly modify metadata for another service. It's nice that this enables sharing a single postgres db for the metadata but it's still worth allowing them to be separate postgres instances if someone wants to use it that way. |
|
@sadath-12 take a look at #1168 when you have a chance. This removes the requirement to do this rename and greatly simplifies the query service. Now it only relies on a single I know this PR was meant to unblock #1140 which is also achieved by the new PR. Let's revisit that one after this refactor is merged. It should be much easier to make the changes necessary to get a good multi-tenancy setup working for you. |
Summary
closes #1143
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan