dep_check.py: move from pip to setuptools #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg_resources.working_set.entry_keys . This is how upstream wants this done and still works on python * now lists missing modules
added 7 commits
September 8, 2018 15:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated dep_check.py to work on modern systems. Related to bug report here:
#268
dep_check.py in this version uses pkg_resources from the setuptools package instead of pip which no longer works on modern versions of python.
In addition, this new version of dep_check.py prints missing dependencies.
tested working on Python 2.7
$ python2 --version
Python 2.7.15