Skip to content

Conversation

nilarte
Copy link
Contributor

@nilarte nilarte commented Feb 23, 2025

No description provided.

@nilarte
Copy link
Contributor Author

nilarte commented Feb 23, 2025

I have not tested this with actual graduates data yet.
That's a next step to be done.
Still please check we are on right path.
@alexeygrigorev

Copy link
Member

@alexeygrigorev alexeygrigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. We also need to add tests and add some fake profiles so this endpoint actually returns something

Copy link
Member

@alexeygrigorev alexeygrigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot - amazing work! just need to create tests =)

@nilarte nilarte marked this pull request as ready for review June 30, 2025 20:00
@alexeygrigorev alexeygrigorev merged commit 6e9c011 into DataTalksClub:main Aug 12, 2025
@alexeygrigorev
Copy link
Member

Thank you!

alexeygrigorev added a commit that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants