Compute cJSON_Version() at compile time
#858
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As CJSON_VERSION_... macros are known to be constant integers, it is possible to use C macros to transform them to literal strings and to directly use the result in function cJSON_Version. As a side-effect, this makes cJSON_Version thread-safe, as a there is no longer a shared buffer (static char version[15]) shared between threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As
CJSON_VERSION_...macros are known to be constant integers, it is possible to use C macros to transform them to literal strings and to directly use the result in functioncJSON_Version.As a side-effect, this makes
cJSON_Versionthread-safe, as a there is no longer a shared buffer (static char version[15]) shared between threads.