Add removeSelectedRows API method #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an API method that removes all selected rows from the dataset and the DOM.
This change is observed by the already present function _setRowKeys which observes changes to data.splices. I added a call to
Polymer.Collection.applySpliceshere to prevent subsequent select events being thrown with keys that refer to incorrect or non-existing items.Disclaimer:
"I hereby grant you, David-Mulder, a generic right to relicense this contribution under any license and the discretion to license the project as a whole to any parties under those licenses"