Skip to content

Conversation

Davidyz
Copy link
Owner

@Davidyz Davidyz commented Jun 25, 2025

This PR attempts to introduce file locks that will allow using the bundled chroma server with the LSP and MCP servers.

This will also implement some helper classes/functions that simplify the management of chroma clients in case different projects are configured to use different chroma servers.

PS: @rieger-jared, it's likely that this PR will be overlapping with some of the stuff that you're working on in #165. I'm not too worried about this, though, because this is only about the bundled chromadb server, and we probably won't be bundling a bunch of database servers in the vectorcode package?

@Davidyz Davidyz added enhancement New feature or request feature labels Jun 25, 2025
@Davidyz Davidyz force-pushed the feat/filelock branch 3 times, most recently from 7304536 to 27c9a0d Compare June 27, 2025 08:14
@rieger-jared
Copy link

This PR attempts to introduce file locks that will allow using the bundled chroma server with the LSP and MCP servers.

This will also implement some helper classes/functions that simplify the management of chroma clients in case different projects are configured to use different chroma servers.

PS: @rieger-jared, it's likely that this PR will be overlapping with some of the stuff that you're working on in #165. I'm not too worried about this, though, because this is only about the bundled chromadb server, and we probably won't be bundling a bunch of database servers in the vectorcode package?

Thanks for the heads up. I think I'll let you finish this one before continuing as the client manager looks similar to something I was doing. Plus I think I need to spend a little more time evaluating the langchain integration as it seems that using langchain might require changing the way we handle documents as the vector store abstraction in the library expects the documents(60% sure of that).

@Davidyz Davidyz force-pushed the feat/filelock branch 2 times, most recently from 776c4fb to d897463 Compare June 27, 2025 10:52
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (1d71b93) to head (cb5160a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   99.49%   99.75%   +0.25%     
==========================================
  Files          21       21              
  Lines        1589     1627      +38     
==========================================
+ Hits         1581     1623      +42     
+ Misses          8        4       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davidyz Davidyz force-pushed the feat/filelock branch 2 times, most recently from d1425eb to 2c9f01e Compare June 28, 2025 03:33
@Davidyz Davidyz marked this pull request as ready for review June 28, 2025 03:59
@Davidyz Davidyz merged commit 99709a9 into main Jun 28, 2025
@Davidyz Davidyz deleted the feat/filelock branch June 28, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants