-
Notifications
You must be signed in to change notification settings - Fork 36
Implement filelock for db_path
when using the chroma server
#217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7304536
to
27c9a0d
Compare
Thanks for the heads up. I think I'll let you finish this one before continuing as the client manager looks similar to something I was doing. Plus I think I need to spend a little more time evaluating the langchain integration as it seems that using langchain might require changing the way we handle documents as the vector store abstraction in the library expects the documents(60% sure of that). |
776c4fb
to
d897463
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 99.49% 99.75% +0.25%
==========================================
Files 21 21
Lines 1589 1627 +38
==========================================
+ Hits 1581 1623 +42
+ Misses 8 4 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d1425eb
to
2c9f01e
Compare
This PR attempts to introduce file locks that will allow using the bundled chroma server with the LSP and MCP servers.
This will also implement some helper classes/functions that simplify the management of chroma clients in case different projects are configured to use different chroma servers.
PS: @rieger-jared, it's likely that this PR will be overlapping with some of the stuff that you're working on in #165. I'm not too worried about this, though, because this is only about the bundled chromadb server, and we probably won't be bundling a bunch of database servers in the vectorcode package?