Skip to content

Features: Store #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 226 commits into
base: develop
Choose a base branch
from
Open

Features: Store #397

wants to merge 226 commits into from

Conversation

JChonpca
Copy link
Collaborator

@JChonpca JChonpca commented Jul 28, 2025

unittest, torch compatible, docs

JChonpca and others added 18 commits July 11, 2025 13:37
* add docs of /features/__rlt__

* u

* u

* Update features.py

---------

Co-authored-by: Jiacheng Huang <[email protected]>
Co-authored-by: Giovanni Volpe <[email protected]>
* add docs 0f /featuers/__le__

* u

---------

Co-authored-by: Jiacheng Huang <[email protected]>
* add docs of  /features/__rle__

* u

* u

* Update features.py

---------

Co-authored-by: Jiacheng Huang <[email protected]>
Co-authored-by: Giovanni Volpe <[email protected]>
* add docs 0f /features/__rge__

* u

* u

* right ,

* Update features.py

---------

Co-authored-by: Jiacheng Huang <[email protected]>
Co-authored-by: Giovanni Volpe <[email protected]>
* add docs of /features/__xor__

* remove blank spaces

---------

Co-authored-by: Jiacheng Huang <[email protected]>
* add docs of /features/__rand__

* Update features.py

---------

Co-authored-by: Jiacheng Huang <[email protected]>
Co-authored-by: Giovanni Volpe <[email protected]>
@JChonpca JChonpca requested review from mirjagranfors and Pwhsky July 28, 2025 06:21
Jiacheng Huang added 2 commits July 28, 2025 09:25
@JChonpca JChonpca changed the title Update /features/store Features: Store Jul 28, 2025
Copy link
Collaborator

@mirjagranfors mirjagranfors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I made a few minor changes.

I don't really understand why there are changes in the DTAT391B_sources.folder tutorial in this PR, but I also don't think that it matters, since you haven't changed any of the content of the tutorial.

@JChonpca
Copy link
Collaborator Author

JChonpca commented Jul 29, 2025

Thanks for the review from @mirjagranfors.

For the difference in the DTAT391B_sources.folder tutorial, I have no idea about it. I did not get a conflict notification when I merged the Develop branch to this branch in the latest. I will merge once again to see what will happen (Nothing happened).

This will also appear in #400. But please ignore it in final merge

@JChonpca JChonpca requested a review from giovannivolpe July 31, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants