-
Notifications
You must be signed in to change notification settings - Fork 57
Features: Store #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Features: Store #397
Conversation
* add docs of /features/__rlt__ * u * u * Update features.py --------- Co-authored-by: Jiacheng Huang <[email protected]> Co-authored-by: Giovanni Volpe <[email protected]>
* add docs 0f /featuers/__le__ * u --------- Co-authored-by: Jiacheng Huang <[email protected]>
* add docs of /features/__rle__ * u * u * Update features.py --------- Co-authored-by: Jiacheng Huang <[email protected]> Co-authored-by: Giovanni Volpe <[email protected]>
Co-authored-by: Jiacheng Huang <[email protected]>
* add docs 0f /features/__rge__ * u * u * right , * Update features.py --------- Co-authored-by: Jiacheng Huang <[email protected]> Co-authored-by: Giovanni Volpe <[email protected]>
* add docs of /features/__xor__ * remove blank spaces --------- Co-authored-by: Jiacheng Huang <[email protected]>
* add docs of /features/__rand__ * Update features.py --------- Co-authored-by: Jiacheng Huang <[email protected]> Co-authored-by: Giovanni Volpe <[email protected]>
Co-authored-by: Jiacheng Huang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I made a few minor changes.
I don't really understand why there are changes in the DTAT391B_sources.folder tutorial in this PR, but I also don't think that it matters, since you haven't changed any of the content of the tutorial.
Thanks for the review from @mirjagranfors. For the difference in the DTAT391B_sources.folder tutorial, I have no idea about it. I did not get a conflict notification when I merged the Develop branch to this branch in the latest. I will merge once again to see what will happen (Nothing happened). This will also appear in #400. But please ignore it in final merge |
unittest, torch compatible, docs