Skip to content

Conversation

ReynardoEW
Copy link
Member

DefiLlama/defillama-server#10489 < need this first pr before is broken due to cors problem

@ReynardoEW ReynardoEW requested a review from mintdart August 25, 2025 07:35
@mintdart mintdart requested a review from vrtnd August 25, 2025 10:57
@mintdart
Copy link
Contributor

most csv downloads are instant as the data is already there on pai ge which we use for charts, tables etc , so no need of a loading indicator for those buttons

i changed the CsvDownloadButton component to accept prepareCsv function or onClick & isLoading

if the csv depends on an external api , we need to use onClick & isLoading props

if not use prepareCsv prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants