feat: added user feedback on why liking the dashboard is not clickable #2183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mintdart
reviewed
Oct 11, 2025
| <Tooltip | ||
| content="Views" | ||
| render={<p />} | ||
| className="flex items-center gap-1 rounded-md border border-(--cards-border) px-1.5 py-1 text-xs text-(--text-disabled)" |
There was a problem hiding this comment.
why remove this color ? we use this text color to differentiate it from like button as this isn't clickable
There was a problem hiding this comment.
The reason I removed it is to make it consistent with the other two buttons.
mintdart
reviewed
Oct 11, 2025
| disabled={isLiking} | ||
| /> | ||
| } | ||
| className={`hover:not-disabled:pro-btn-blue focus-visible:not-disabled:pro-btn-blue flex items-center gap-1 rounded-md border border-(--form-control-border) px-1.5 py-1 text-xs hover:border-transparent focus-visible:border-transparent`} |
There was a problem hiding this comment.
user will also need to subscribe to like a dashboard, i don't think toast is helpful
There was a problem hiding this comment.
Should we redirect users to the sign in page or show a better toast message? rn when someone clicks the like button, it’s disabled if they are not signed it, I felt it’s better to give feedback on what’s missing before they can like it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.