Skip to content

Add Frankencoin protocol revenue adapter #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Frankencoin protocol revenue adapter #3880

wants to merge 4 commits into from

Conversation

samclassix
Copy link

@samclassix samclassix commented Jul 30, 2025 •
edited
Loading

Test Output

❯ npm test fees frankencoin 2025-07-30

[email protected] test
ts-node --transpile-only cli/testAdapter.ts fees frankencoin 2025-07-30

🦙 Running FRANKENCOIN adapter 🦙

Start Date: Tue, 29 Jul 2025 00:00:00 GMT
End Date: Wed, 30 Jul 2025 00:00:00 GMT

ETHEREUM 👇
Backfill start time: 28/10/2023
Daily fees: 994.10 k
Daily revenue: 968.76 k
Daily protocol revenue: 968.76 k
End timestamp: 1753833599 (2025-07-29T23:59:59.000Z)

@llamabutler
Copy link

The frankencoin adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees frankencoin

🦙 Running FRANKENCOIN adapter 🦙
---------------------------------------------------
Start Date:	Tue, 29 Jul 2025 06:22:40 GMT
End Date:	Wed, 30 Jul 2025 06:22:40 GMT
---------------------------------------------------

ETHEREUM 👇
Backfill start time: 28/10/2023
Daily fees: 994.10 k
Daily revenue: 968.76 k
Daily protocol revenue: 968.76 k
End timestamp: 1753856559 (2025-07-30T06:22:39.000Z)

@samclassix samclassix mentioned this pull request Jul 30, 2025
Open
16 tasks
@treeoflife2 treeoflife2 self-assigned this Aug 4, 2025
@treeoflife2 treeoflife2 self-requested a review August 4, 2025 09:43
treeoflife2
treeoflife2 requested changes Aug 4, 2025
View reviewed changes
Copy link
Member

@treeoflife2 treeoflife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

fees/frankencoin/index.ts Outdated
limit: 1,
) {
items {
profits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need more information regarding the how profit/loss are calculated? as daily ~1M revenue for 30m TVL looks very high, so please provide more information, thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoi

the graph table is just an entry of all profits and losses. And therefore its the accumulated profits/losses of all times. I thought the defillama api is regularly fetching the numbers and calculate the difference between the fetches and therefore knows how much the daily values would be.

{
  "amount": "167395000000000000000", **<-- individual change per this entry**
  "chainId": 1,
  "count": "353",
  "created": "1754328179",
  "kind": "Profit", **<-- this entry reflects a profit change**
  "losses": "20513419393164404266345", **<-- all time losses (accum.)**
  "minter": "0x5ed0d010e20c262cc264aaf060fb9e3037cd383e",
  "perFPS": "90297226610802112896",
  "profits": "802597897386182421051766" **<-- all time profits (accum.)**
},

maybe i have to refactor this.
So you need explicitly the daily p/l?
How does the fetcher function know which date it is?

Copy link
Member

@treeoflife2 treeoflife2 Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samclassix you can read more about how dimension adapter works here(https://docs.llama.fi/list-your-project/other-dashboards)
but i will give you tldr

we run it each day at UTC 00:00 if it's version 1 adapter(default)
so we have options in fetch function, which has options.starttimestamp and options.endtimestamp
which will be previous day start and end timestamp.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand how all profit goes to protocol, isn't there any yield for token holders?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand how all profit goes to protocol, isn't there any yield for token holders?

the protocol uses a token "Frankencoin Pool Share" which acts like the governance token, receiver of the earnings and also takes the losses of the protocol.

https://frankencoin.com/fps.html
https://app.frankencoin.com/equity

g1nt0ki
g1nt0ki requested changes Sep 12, 2025
View reviewed changes
Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samclassix can you please fix the adapter, the adapter is supposed to return daily value. Else, I will close this as stale

@samclassix
Copy link
Author

@samclassix can you please fix the adapter, the adapter is supposed to return daily value. Else, I will close this as stale

will look into it beginning of next week.

@llamabutler
Copy link

The frankencoin adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees frankencoin

🦙 Running FRANKENCOIN adapter 🦙
---------------------------------------------------
Start Date:	Sun, 14 Sep 2025 10:19:33 GMT
End Date:	Mon, 15 Sep 2025 10:19:33 GMT
---------------------------------------------------

ETHEREUM 👇
Backfill start time: 28/10/2023
Daily fees: 0
Daily revenue: 0
Daily protocol revenue: 0
End timestamp: 1757931572 (2025-09-15T10:19:32.000Z)

@llamabutler
Copy link

The frankencoin adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees frankencoin

🦙 Running FRANKENCOIN adapter 🦙
---------------------------------------------------
Start Date:	Sun, 14 Sep 2025 10:20:40 GMT
End Date:	Mon, 15 Sep 2025 10:20:40 GMT
---------------------------------------------------

ETHEREUM 👇
Backfill start time: 28/10/2023
Daily fees: 0
Daily revenue: 0
Daily protocol revenue: 0
End timestamp: 1757931639 (2025-09-15T10:20:39.000Z)

@llamabutler
Copy link

The frankencoin adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees frankencoin

🦙 Running FRANKENCOIN adapter 🦙
---------------------------------------------------
Start Date:	Sun, 14 Sep 2025 10:29:58 GMT
End Date:	Mon, 15 Sep 2025 10:29:58 GMT
---------------------------------------------------

ETHEREUM 👇
Backfill start time: 28/10/2023
Daily fees: 0
Daily revenue: 0
Daily protocol revenue: 0
End timestamp: 1757932197 (2025-09-15T10:29:57.000Z)

@llamabutler
Copy link

The frankencoin adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees frankencoin

🦙 Running FRANKENCOIN adapter 🦙
---------------------------------------------------
Start Date:	Sun, 14 Sep 2025 10:54:37 GMT
End Date:	Mon, 15 Sep 2025 10:54:37 GMT
---------------------------------------------------

ETHEREUM 👇
Backfill start time: 28/10/2023
Daily fees: 0
Daily revenue: 0
Daily protocol revenue: 0
Daily supply side revenue: 0
End timestamp: 1757933676 (2025-09-15T10:54:36.000Z)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1nt0ki g1nt0ki Awaiting requested review from g1nt0ki

@treeoflife2 treeoflife2 Awaiting requested review from treeoflife2

Assignees

@treeoflife2 treeoflife2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samclassix @llamabutler @g1nt0ki @treeoflife2