Skip to content

Conversation

vitusha-rat
Copy link
Contributor

No description provided.

@llamabutler
Copy link

The lab-terminal.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees lab-terminal.ts

🦙 Running LAB-TERMINAL.TS adapter 🦙
---------------------------------------------------
Start Date:	Sun, 31 Aug 2025 20:26:56 GMT
End Date:	Mon, 01 Sep 2025 20:26:56 GMT
---------------------------------------------------

Error: Request failed with status code 401
    at queryDune (/home/runner/work/dimension-adapters/dimension-adapters/helpers/dune.ts:121:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetch (/home/runner/work/dimension-adapters/dimension-adapters/fees/lab-terminal.ts:22:19)
    at async getChainResult (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:206:18)
    at async Promise.all (index 0)
    at async _runAdapter (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:159:20)
    at async /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:69:24 {
  axiosError: 'Dune API Key is invalid',
  chain: 'solana'
}

@llamabutler
Copy link

The lab-terminal.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees lab-terminal.ts

🦙 Running LAB-TERMINAL.TS adapter 🦙
---------------------------------------------------
Start Date:	Mon, 01 Sep 2025 07:28:51 GMT
End Date:	Tue, 02 Sep 2025 07:28:51 GMT
---------------------------------------------------

Error: Request failed with status code 401
    at queryDune (/home/runner/work/dimension-adapters/dimension-adapters/helpers/dune.ts:121:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetch (/home/runner/work/dimension-adapters/dimension-adapters/fees/lab-terminal.ts:22:19)
    at async getChainResult (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:206:18)
    at async Promise.all (index 0)
    at async _runAdapter (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:159:20)
    at async /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:69:24 {
  axiosError: 'Dune API Key is invalid',
  chain: 'solana'
}

@g1nt0ki g1nt0ki self-assigned this Sep 2, 2025
@llamabutler
Copy link

The lab-terminal.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees lab-terminal.ts

🦙 Running LAB-TERMINAL.TS adapter 🦙
---------------------------------------------------
Start Date:	Mon, 01 Sep 2025 00:00:00 GMT
End Date:	Tue, 02 Sep 2025 00:00:00 GMT
---------------------------------------------------

Error: Request failed with status code 401
    at queryDune (/home/runner/work/dimension-adapters/dimension-adapters/helpers/dune.ts:121:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetch (/home/runner/work/dimension-adapters/dimension-adapters/fees/lab-terminal.ts:50:15)
    at async getChainResult (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:204:18)
    at async Promise.all (index 0)
    at async _runAdapter (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:159:20)
    at async /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:69:24 {
  axiosError: 'Dune API Key is invalid',
  chain: 'solana'
}

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitusha-rat thanks for the PR, can you share some project info and how we can track how much is sent back to users as referral fees, we need to exclude it from the revenue

@vitusha-rat
Copy link
Contributor Author

@vitusha-rat thanks for the PR, can you share some project info and how we can track how much is sent back to users as referral fees, we need to exclude it from the revenue

Yes, sure!
Where can I check what project info you need for listing?

@vitusha-rat
Copy link
Contributor Author

vitusha-rat commented Sep 4, 2025

@g1nt0ki

Thanks for the feedback!
We’d prefer to display only the total fees received. The reason is that our referral programs can have multiple tiers (some start with a smaller percentage and later increase), so it’s not straightforward to calculate a single, exact referral payout number.

Also, we’ve checked other platforms (e.g. PumpFun, Axiom, and a few others), and they all show only the gross fees without subtracting referral payouts. We’d like to keep it consistent with that approach.

For more context:

@vitusha-rat vitusha-rat requested a review from g1nt0ki September 5, 2025 10:26
Copy link
Contributor Author

@vitusha-rat vitusha-rat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here

@vitusha-rat
Copy link
Contributor Author

@g1nt0ki
Is there any updates?

@g1nt0ki
Copy link
Member

g1nt0ki commented Sep 9, 2025

@vitusha-rat bit hesitant to merge it because I still would like to avoid tracking referral as revenue, even a delayed off chain data of how much was paid out would work.

We are not tracking this as revenue for pump, yes, it is wrong for axiom, but adding incorrect data for another protocol only makes the issue worse not better

@vitusha-rat
Copy link
Contributor Author

@g1nt0ki

Thank you for clarifying. I have a better understanding of your position now. Since your platform is used for analytics and marketing research, data accuracy is undoubtedly the top priority.

We completely share that value. However, in this case, it's not about misrepresenting data, but about aligning with the accepted industry standard. The platforms we are compared against (e.g.,Axiom) all display gross revenue. If we are the only ones showing revenue after subtracting referral payouts, it will create confusion and put us at an unfair disadvantage in comparisons.

Perhaps we could find a solution that respects both your principle of accuracy and our need for a fair comparison? For example, we could add an optional parameter or a clear note specifying that the figure represents gross revenue, as is standard on other platforms.

What are your thoughts on this?

@vitusha-rat
Copy link
Contributor Author

@g1nt0ki
Just wanted to follow up on this. Any thoughts on the proposal above?

@g1nt0ki
Copy link
Member

g1nt0ki commented Sep 12, 2025

we are reaching out to the axiom team and trying to pull the payout data so we can exclude it from the revenue, thats why I havent merged this

Other option here is, we track only your fees and not the revenue

@vitusha-rat
Copy link
Contributor Author

we are reaching out to the axiom team and trying to pull the payout data so we can exclude it from the revenue, thats why I havent merged this

Other option here is, we track only your fees and not the revenue

Thank you for the reply!
Displaying only the fees is the great idea!

Should we remove revenue fields from function return?

And do you need any additional data for displaying lab on DL? I mean images, links, description?

@llamabutler
Copy link

The lab-terminal.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees lab-terminal.ts

🦙 Running LAB-TERMINAL.TS adapter 🦙
---------------------------------------------------
Start Date:	Sun, 14 Sep 2025 00:00:00 GMT
End Date:	Mon, 15 Sep 2025 00:00:00 GMT
---------------------------------------------------

Error: Request failed with status code 401
    at queryDune (/home/runner/work/dimension-adapters/dimension-adapters/helpers/dune.ts:121:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async fetch (/home/runner/work/dimension-adapters/dimension-adapters/fees/lab-terminal.ts:50:15)
    at async getChainResult (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:204:18)
    at async Promise.all (index 0)
    at async _runAdapter (/home/runner/work/dimension-adapters/dimension-adapters/adapters/utils/runAdapter.ts:159:20)
    at async /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:69:24 {
  axiosError: 'Dune API Key is invalid',
  chain: 'solana'
}

@g1nt0ki g1nt0ki merged commit d43ade3 into DefiLlama:master Sep 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants