-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add lab-terminal adapter #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lab-terminal adapter #4135
Conversation
The lab-terminal.ts adapter exports:
|
The lab-terminal.ts adapter exports:
|
The lab-terminal.ts adapter exports:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitusha-rat thanks for the PR, can you share some project info and how we can track how much is sent back to users as referral fees, we need to exclude it from the revenue
Yes, sure! |
Thanks for the feedback! Also, we’ve checked other platforms (e.g. PumpFun, Axiom, and a few others), and they all show only the gross fees without subtracting referral payouts. We’d like to keep it consistent with that approach. For more context:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good here
@g1nt0ki |
@vitusha-rat bit hesitant to merge it because I still would like to avoid tracking referral as revenue, even a delayed off chain data of how much was paid out would work. We are not tracking this as revenue for pump, yes, it is wrong for axiom, but adding incorrect data for another protocol only makes the issue worse not better |
Thank you for clarifying. I have a better understanding of your position now. Since your platform is used for analytics and marketing research, data accuracy is undoubtedly the top priority. We completely share that value. However, in this case, it's not about misrepresenting data, but about aligning with the accepted industry standard. The platforms we are compared against (e.g.,Axiom) all display gross revenue. If we are the only ones showing revenue after subtracting referral payouts, it will create confusion and put us at an unfair disadvantage in comparisons. Perhaps we could find a solution that respects both your principle of accuracy and our need for a fair comparison? For example, we could add an optional parameter or a clear note specifying that the figure represents gross revenue, as is standard on other platforms. What are your thoughts on this? |
@g1nt0ki |
we are reaching out to the axiom team and trying to pull the payout data so we can exclude it from the revenue, thats why I havent merged this Other option here is, we track only your fees and not the revenue |
Thank you for the reply! Should we remove revenue fields from function return? And do you need any additional data for displaying lab on DL? I mean images, links, description? |
The lab-terminal.ts adapter exports:
|
No description provided.