-
Notifications
You must be signed in to change notification settings - Fork 956
yieldoor: add eth looped vault #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumping this |
@d-grasshopper can u give a brief explanation why the new dependencies are required? |
Of course, we use their SDK, since they have all the necessary math and on-chain calls to calculate Morpho positions with interest up to a timestamp in their classes/helpers. |
hm, have u tried using our sdk for doing this? for conext: i'm trying to keep external sdks to a min, and only add where really necessary |
Hi, yes, I've investigated it, I can reimplement most of the logic, but I will also have to add/implement some of their math lib, i.e - https://github.com/morpho-org/sdks/blob/59ba43e6a011a23291b9b2a4d75f5e9d730e38c1/packages/blue-sdk/src/math/AdaptiveCurveIrmLib.ts#L65. So that's why I went with just importing their SDK. I'll leave the decision to you. |
lets try an implementation without these dependencies, its fine if you copy over bits from their repo |
Hi, I've updated the code to remove the Morpho SDK dependency. I'm getting a failure in the pipeline due to The Graph API key requiring payment. Could you help out with this and let me know if I need to supply a key, or if you need to update it on your side? |
gm, thx. we dont expose the graph key in our tests, i'll run ur code locally. can u confirm that it works for u using your own key? |
GM, yes, it does work |
Hi, I appreciate the extra circumstances here, just bumping to see if we can get this moving. Staying open for any required changes as well. |
Add Yieldoor's Ethereum Looped Vault
Questions to reviewers