Skip to content

yieldoor: add eth looped vault #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025

Conversation

d-grasshopper
Copy link
Contributor

Add Yieldoor's Ethereum Looped Vault

Questions to reviewers

  1. I've added a dependency to the Morpho SDK. Please advise if that's ok, if not, could you offer another solution (if you've perhaps been through a similar situation before)?
  2. I've tried to optimize the many calls made, but any suggestions are welcome

@d-grasshopper
Copy link
Contributor Author

Bumping this

@slasher125
Copy link
Collaborator

@d-grasshopper can u give a brief explanation why the new dependencies are required?

@d-grasshopper
Copy link
Contributor Author

Of course, we use their SDK, since they have all the necessary math and on-chain calls to calculate Morpho positions with interest up to a timestamp in their classes/helpers.

@slasher125
Copy link
Collaborator

hm, have u tried using our sdk for doing this?

for conext: i'm trying to keep external sdks to a min, and only add where really necessary

@d-grasshopper
Copy link
Contributor Author

Hi, yes, I've investigated it, I can reimplement most of the logic, but I will also have to add/implement some of their math lib, i.e - https://github.com/morpho-org/sdks/blob/59ba43e6a011a23291b9b2a4d75f5e9d730e38c1/packages/blue-sdk/src/math/AdaptiveCurveIrmLib.ts#L65.

So that's why I went with just importing their SDK. I'll leave the decision to you.

@slasher125
Copy link
Collaborator

Hi, yes, I've investigated it, I can reimplement most of the logic, but I will also have to add/implement some of their math lib, i.e - https://github.com/morpho-org/sdks/blob/59ba43e6a011a23291b9b2a4d75f5e9d730e38c1/packages/blue-sdk/src/math/AdaptiveCurveIrmLib.ts#L65.

So that's why I went with just importing their SDK. I'll leave the decision to you.

lets try an implementation without these dependencies, its fine if you copy over bits from their repo

@d-grasshopper
Copy link
Contributor Author

Hi, I've updated the code to remove the Morpho SDK dependency. I'm getting a failure in the pipeline due to The Graph API key requiring payment. Could you help out with this and let me know if I need to supply a key, or if you need to update it on your side?

@slasher125
Copy link
Collaborator

gm, thx. we dont expose the graph key in our tests, i'll run ur code locally. can u confirm that it works for u using your own key?

@d-grasshopper
Copy link
Contributor Author

GM, yes, it does work

@d-grasshopper
Copy link
Contributor Author

Hi, I appreciate the extra circumstances here, just bumping to see if we can get this moving. Staying open for any required changes as well.

@slasher125 slasher125 merged commit fc4b74c into DefiLlama:master Jul 31, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants