Add Typescript Types #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BendaCoding
commented
Dec 5, 2019
BendaCoding
commented
- add ts types
- add rollup ts plugin to build with types
Jazzepi
reviewed
Jan 16, 2020
| /** | ||
| * Whether it is sticky, or not. | ||
| */ | ||
| sticky?: string; |
There was a problem hiding this comment.
You have to be careful this thing isn't a boolean. Look at the source code and the way it's actually used. The fact that it's a string is crazy.
Sticky's only possible value is null/undefined or https://getbootstrap.com/docs/4.0/utilities/position/ the string 'top' because of how it gets used here. https://github.com/DesignRevision/shards-react/blob/master/components/navbar/Navbar.js#L38
JeanOUINA
added a commit
to JeanOUINA/shards-react
that referenced
this pull request
May 1, 2021
|
Hey! Would love to see this merged if possible to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.