fix: make clippy happy

[r-vdp]

Description

Checklist

• Built with cargo build
• Formatted with cargo fmt
• Linted with cargo clippy
• Ran tests with cargo test
• Added or updated relevant tests (leave unchecked if not applicable)
• Added or updated relevant documentation (leave unchecked if not applicable)

Summary by CodeRabbit

• Tests

  • Standardized JSON parsing in tests and removed unnecessary references.
  • Updated test helpers to use Path and slices for clearer, more flexible parameters.
  • Simplified kernel parameter setup for readability and consistency.

• Refactor

  • Minor internal cleanups in test setup to align types and reduce verbosity.

• Chores

  • No user-facing changes; behavior and public APIs remain unchanged.

[coderabbitai]

Walkthrough

Test code was refactored to pass JSON strings by value to serde_json::from_str, adjust kernel parameter setup to array literals, and prefer Path and slice types (&Path, &[String]) over PathBuf and &Vec<String]. Some test helpers now call generation.keep(). No public APIs were changed.

Changes

Cohort / File(s)	Summary of Changes
Serde deserialization arg updates bootspec/src/generation.rs	Updated tests to pass JSON strings by value to serde_json::from_str::<T>(json) instead of by reference (removed &json), aligning generic usage accordingly.
Kernel params initialization refactor bootspec/src/generation.rs	Replaced vec![...] initialization with array literal [ ... ], preserving mapping to String via iteration for final collection.
Path and slice parameterization in tests bootspec/src/v1.rs	Switched test parameters from &PathBuf to &Path and from &Vec<String> to &[String]. Updated call sites to pass slices and Path values; imports adjusted to include both Path and PathBuf.
Test helper invocation tweak bootspec/src/v1.rs	Modified test scaffolding to use generation.keep() in place of into_path() where applicable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

In burrows of code I twitch my nose,
Arrays replace vecs—how tidy it goes!
Paths trimmed to slices, neat as a nib,
JSON by value—no borrow to crib.
I thump in delight, small hops of cheer—
Tests run smoother; carrots appear. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly indicates that the pull request’s primary purpose is to address Clippy lint warnings and directly reflects the test adjustments and code changes made to satisfy those lints.
Docstring Coverage	✅ Passed	Docstring coverage is 81.82% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58da8c3 and cf2b58e.

📒 Files selected for processing (2)

• bootspec/src/generation.rs (9 hunks)
• bootspec/src/v1.rs (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

bootspec/src/generation.rs (1)

validate/src/main.rs (1)

• serde_json (22-22)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: NixFormatting
• GitHub Check: build
• GitHub Check: SynthesizeIntegration
• GitHub Check: format

🔇 Additional comments (5)

bootspec/src/v1.rs (3)

216-216: LGTM!

The Path import is necessary for the idiomatic function signature changes that follow.

---

222-228: LGTM!

The function signature changes are idiomatic Rust:

• &Path instead of PathBuf for borrowed path parameters
• &[String] instead of &Vec<String> for slice parameters (more flexible, accepts both Vec and arrays)

These align with standard clippy recommendations.

---

258-259: LGTM!

Using keep() is clearer than into_path() for expressing the intent to prevent automatic deletion of the temporary directory.

bootspec/src/generation.rs (2)

81-81: LGTM!

Removing the unnecessary & before json in from_str calls is correct. The json variables are already &str, so passing them directly avoids the unnecessary double reference (&&str).

Also applies to: 134-134, 195-195, 272-272, 336-336, 367-367, 427-427, 488-488, 550-550

---

141-153: LGTM!

Using array literals [...] instead of vec![...] when immediately calling .iter() is more efficient. It avoids an unnecessary heap allocation since arrays can be iterated directly.

Also applies to: 201-213, 278-290, 373-385, 433-445

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}