feat: add support for DVC pipe proxy in FFI #938
Conversation
pacmancoder
force-pushed
the
feat/ffi-dvc-proxy
branch
from
42142ed to
d9512e9
Compare
Coverage Report 🤖 ⚙️Past: New: Diff: -0.03% [this comment will be updated automatically] |
pacmancoder
force-pushed
the
feat/ffi-dvc-proxy
branch
from
d9512e9 to
c5bbc32
Compare
| pub fn next_message(&self) -> Result<Option<Box<DvcPipeProxyMessage>>, Box<IronRdpError>> { | ||
| Ok(self.0.next_message().map(DvcPipeProxyMessage).map(Box::new)) | ||
| } | ||
|
|
||
| pub fn next_message_blocking(&self) -> Result<Box<DvcPipeProxyMessage>, Box<IronRdpError>> { | ||
| let message = self.0.next_message_blocking().map(DvcPipeProxyMessage).map(Box::new)?; | ||
|
|
||
| Ok(message) | ||
| } |
There was a problem hiding this comment.
suggestion: I suppose next_message will return None when no message is ready to be received? The conventional naming in Rust is to use try_: try_next_message for the non-blocking one, and next_message for the blocking one. May also be a good idea to add documentation.
There was a problem hiding this comment.
The naming/signature was made consistent with other similar type in FFI: https://github.com/Devolutions/IronRDP/blob/feat/ffi-dvc-proxy/ffi/src/clipboard/windows.rs#L37-L46
There was a problem hiding this comment.
I see 🤔
I would be in favor of changing that, but can be a follow up!
pacmancoder
force-pushed
the
feat/ffi-dvc-proxy
branch
3 times, most recently
from
6355c3c to
fc4540f
Compare
pacmancoder
force-pushed
the
feat/ffi-dvc-proxy
branch
from
fc4540f to
e8b1cb6
Compare
|
Oh no, I squashed 🥹 |
No description provided.