Skip to content

run() now returns void #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

run() now returns void #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [[*next-version*]] - YYYY-MM-DD
### Changed
- **BC Breaking** - The return type of `ModuleInterface#run()` is now `void`.
This will break any subtypes that did not declare a return type,
because `void` is more specific than `mixed`.

## [0.2.0-alpha1] - 2020-04-10
### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/ModuleInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ public function setup() : ServiceProviderInterface;
*
* @throws ModuleExceptionInterface If the module failed to run.
*/
public function run(ContainerInterface $c);
public function run(ContainerInterface $c): void;
}