Skip to content

Horizontal nav #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Horizontal nav #930

wants to merge 7 commits into from

Conversation

floydchenchen
Copy link
Contributor

No description provided.

@floydchenchen
Copy link
Contributor Author

with the latest update (4036269), the style is partially working for horizontal nav if we build it the normal way (vs build it by data). Specifically, the animation of NavItems in subNav is missing.

If we build the horizontal nav by data (using _buildNavByData function), the style of the NavItem in subNav will break.

@Magneticmagnum
Copy link
Contributor

Good work, mostly this is feature complete with the exception of building Nav via data prop. Could you fix the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floydchenchen @Magneticmagnum