-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Stores: Externally tracked state and reactive collections #4483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4,958
−436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a bunch more methods to result and option for stores. There are still some methods we don't support on Result, Option, and data structures like String that won't benefit from an optimized Store version. I would rather add those in a followup PR as this PR is already large and those changes are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on top of #4413 with the store implementation. I expect the design for stores to take longer to resolve so this is pulled out into a separate non-breaking PR which could be released in a patch version in 0.7
We could publish stores as an external crate outside of the prelude with a decoupled version for the first few releases. Stores don't integrate deeply with any other crates in the workspace so maintaining a separate version seems relatively simple
TODO: