fix: correctly reset tempo on frame change when retrieve channel state setting is used #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to correctly reset the tempo on frame change when the retrieve channel state setting is used.
Eg. right now if you have a groove
Oxx
orFxx
in only the first pattern and change the frame while playing back, the tempo is reset using the default speed/tempo instead of the retrieved groove/speed settings. This PR changes this to correctly reset the tempo to the actual groove setting used so the tempo stays consistent even when changing frames during playback.It looks like there was some groove/speed handling in there already (which didn't work using retrieve channel state) so I split that code with an if/else depending on
General.bRetrieveChanState
and took the working code fromCSoundGen::ApplyGlobalState()
. Maybe there's a smarter way to fix this, if that's the case feel free to edit.fixes #357
Changes in this PR: