Disable some rails cops inline

Author: esoterik

.rubocop_todo.yml

@@ -121,13 +121,6 @@ Rails/HelperInstanceVariable:
     - 'app/helpers/devise_helper.rb'
     - 'app/helpers/petition_helper.rb'
 
-# Offense count: 2
-# Configuration parameters: Include.
-# Include: app/models/**/*.rb
-Rails/InverseOf:
-  Exclude:
-    - 'app/models/action_page.rb'
-
 # Offense count: 6
 # Configuration parameters: Include.
 # Include: app/controllers/**/*.rb
@@ -139,19 +132,6 @@ Rails/LexicallyScopedActionFilter:
     - 'app/controllers/sessions_controller.rb'
     - 'app/controllers/tools_controller.rb'
 
-# Offense count: 9
-# Configuration parameters: Blacklist, Whitelist.
-# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
-Rails/SkipsModelValidations:
-  Exclude:
-    - 'app/controllers/registrations_controller.rb'
-    - 'app/controllers/users_controller.rb'
-    - 'app/models/congress_scorecard.rb'
-    - 'lib/tasks/ahoy.rake'
-    - 'lib/tasks/congress.rake'
-    - 'spec/requests/congress_messages_spec.rb'
-    - 'spec/tasks/signatures_spec.rb'
-
 # Offense count: 3
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb

app/controllers/registrations_controller.rb

@@ -31,7 +31,9 @@ def handle_nonunique_email
       existing.update(sign_up_params) unless existing.confirmed?
 
       if resource.persisted?
+        # rubocop:todo Rails/SkipsModelValidations
         resource.update_attribute(:unconfirmed_email, account_update_params[:email])
+        # rubocop:enable Rails/SkipsModelValidations
         flash[:notice] = I18n.t "devise.registrations.update_needs_confirmation"
         respond_with resource, location: after_update_path_for(resource)
       else

app/controllers/tools_controller.rb

@@ -155,7 +155,7 @@ def set_user
   end
 
   # rubocop:todo Naming/MemoizedInstanceVariableName
-  def set_action_page # rubocop:todo Naming/MemoizedInstanceVariableName
+  def set_action_page
     @action_page ||= ActionPage.find_by(id: params[:action_id])
   end
   # rubocop:enable Naming/MemoizedInstanceVariableName

app/controllers/users_controller.rb

@@ -21,7 +21,9 @@ def update
   end
 
   def clear_activity
+    # rubocop:todo Rails/SkipsModelValidations
     current_user.events.update_all(user_id: nil)
+    # rubocop:enable Rails/SkipsModelValidations
     redirect_to user_path
   end
 

app/models/action_page.rb

@@ -36,9 +36,13 @@ class ActionPage < ActiveRecord::Base
   belongs_to :congress_message_campaign
   belongs_to :call_campaign
   belongs_to :category, optional: true
+  # rubocop:todo Rails/InverseOf
   belongs_to :active_action_page_for_redirect, class_name: "ActionPage",
                                                foreign_key: "archived_redirect_action_page_id"
+  # rubocop:enable Rails/InverseOf
+  # rubocop:todo Rails/InverseOf
   belongs_to :author, class_name: "User", foreign_key: :user_id, optional: true
+  # rubocop:enable Rails/InverseOf
 
   accepts_nested_attributes_for :tweet, :petition, :email_campaign,
                                 :call_campaign, :congress_message_campaign, :affiliation_types, :partnerships,

app/models/congress_scorecard.rb

@@ -6,6 +6,8 @@ class CongressScorecard < ActiveRecord::Base
   belongs_to :action_page
 
   def increment!
+    # rubocop:todo Rails/SkipsModelValidations
     CongressScorecard.increment_counter(:counter, id) # Increments counter atomically
+    # rubocop:enable Rails/SkipsModelValidations
   end
 end

lib/related_content.rb

@@ -38,7 +38,7 @@ def image
   attr_reader :url, :page, :loaded_successfully
 
   # rubocop:todo Naming/MemoizedInstanceVariableName
-  def open_page # rubocop:todo Naming/MemoizedInstanceVariableName
+  def open_page
     @page ||= Nokogiri::HTML(open(url))
   end
   # rubocop:enable Naming/MemoizedInstanceVariableName

lib/tasks/ahoy.rake

@@ -1,7 +1,9 @@
 namespace :ahoy do
   desc "Fix name for view events"
   task fix_views: :environment do
+    # rubocop:todo Rails/SkipsModelValidations
     Ahoy::Event.where("properties ->> 'actionType' = 'view'").update_all(name: "View")
+    # rubocop:enable Rails/SkipsModelValidations
   end
 
   task fix_action_page_ids: :environment do

lib/tasks/congress.rake

@@ -43,9 +43,11 @@ namespace :congress do
           twitter_id = info["social"]["twitter"]
           next unless twitter_id
 
+          # rubocop:todo Rails/SkipsModelValidations
           CongressMember
             .where(bioguide_id: info["id"]["bioguide"])
             .update_all(twitter_id: twitter_id)
+          # rubocop:enable Rails/SkipsModelValidations
         end
       end
     end

spec/requests/congress_messages_spec.rb

@@ -74,7 +74,9 @@ def get_congress_message_form # rubocop:todo Naming/AccessorMethodName
 
       it "to target bioguide_ids" do
         campaign = FactoryGirl.create(:congress_message_campaign, :targeting_bioguide_ids)
+        # rubocop:todo Rails/SkipsModelValidations
         action_page.update_attribute(:congress_message_campaign, campaign)
+        # rubocop:enable Rails/SkipsModelValidations
         get_congress_message_form
         expect(response.body).to include("C000880")
         expect(response.body).not_to include("A000360")
@@ -83,7 +85,9 @@ def get_congress_message_form # rubocop:todo Naming/AccessorMethodName
       it "to target a single chamber" do
         members.last.update(chamber: "house", district: 10)
         campaign = FactoryGirl.create(:congress_message_campaign, :targeting_senate)
+        # rubocop:todo Rails/SkipsModelValidations
         action_page.update_attribute(:congress_message_campaign, campaign)
+        # rubocop:enable Rails/SkipsModelValidations
         get_congress_message_form
         expect(response.body).to include("C000880")
         expect(response.body).not_to include("A000360")