WIP: Dependency, Rails, and Ruby upgrade main branch #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix action creation
Fix docker build after explicitly requiring fiddle
Makes this a little bit more flexible since we ran into an issue with expecting there to _not_ be an https prefix on the URL when moving to use Digital Ocean, which seems a bit counterintuitive.
amazon_bucket_url accepts both https:// and non-http prefixed URLs
Ensure SourceFile#full_url returns a string
Expect S3 bucket urls to include https://
Finish swapping to :system specs
System tests user signin improvements
…tabase containers
* Sets up Github Actions to run tests and linting on CI on every push
* Only specifies to minor version for Ruby in CI, because of inconsistent availability on Ubuntu versions
* Updates linter rules to match current use, and fixes rubocop errors
* Regenerates bundle and rake binstubs
* Remove separate testdb container
* Use existing db container for database. Differentiate connection information by env vars and a separate database name (action_center_test). Also removes test db migration logic from the Docker entrypoint, assuming that we will load the schema in. Updates the CI file accordingly.
* Relies on secrets.yml to make env vars available to application across environments
* Deletes unneeded test-specific db configuration for env var; relies on environment to set instead
* As much as possible, sets any config needed for test in the test env for secrets.yml
* Deletes unused but confusing .env.test
* Copy rather than Add Dockerfile to allow for caching and reduce risk.
* COPY will cache contents in order of declaration, which should help reduce the amount of time it takes to build the image. ADD copies everything anew each time without caching. Also, Docker warns that ADD could unintentionally introduce security risks, including downloading remote files and unpacking archives. https://www.docker.com/blog/docker-best-practices-understanding-the-differences-between-add-and-copy-instructions-in-dockerfiles/
* Remove unused travis.yml file
* Remove FactoryBot line that was initiating db connection on app startup
* Was preventing us from creating a database with bin/rails db:create because it tried to connect to that same database before it was able to be created.
* Remove unmaintained congress images. Repo last updated ~10 years ago, so images were broken anyway.
* Move database env vars to database.yml. Try to reduce number of places where they appear.
---------
Co-authored-by: sylph <[email protected]>
* Refactor state level email actions * Clean up state level refactor + fix its styles * Some small cleanup around state-level actions * Update activism director -> Jason
* Fix admin action page filtering - Adds a system test for filters - Properly symbolize filter params keys before passing to query object --------- Co-authored-by: Christa Hartsock <[email protected]>
The Civic API is going to be shut down in a week or two. We need to remove the corresponding code and decide on if/how to move forward with a new service that provides representative info. In meantime this turns off the state level actions from the user interface (public and admin) and returns a 404 from the corresponding endpoint in the tools controller when STATE_ACTIONS_ENABLED is unset. In the future, we can swap out the backend logic and reenable by setting the env var to true.
Hide state action behind feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening this so we can track the diff a bit better between
masterand what's been merged into the upgrade branch.When we merge this it'd also be a good opportunity to switch from
mastertomainas the main branch!