-
Notifications
You must be signed in to change notification settings - Fork 54
recover UC example #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
recover UC example #821
Conversation
|
Can't replicate that smt failure for theories/algebra/DynMatrix.eca in my machine. |
|
Are you running with z3 4.8 and cvc5 whatever version is in the docker container? |
|
Looks good to me, Manuel. I didn't run into the SMT issue on my machine, either. Was there anything in particular you wanted my input on? |
$ z3 --version |
@alleystoughton thanks. I tagged you just to give you a thumbs up that I am starting again to think about this. |
We finally have proofs in EasyUC of both the UC composition and dummy adversary theorems (originally, we just had an instance of composition), our translator from the UC DSL into EC is complete, and we're just finishing the SMC example in this new form. Once we get things cleaned up and all on the main branch, I'll ping you. |
strub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the example is recovered, it should be added to the CI.
It is in the standard |
Indeed. But note that we have a lot of disabled examples in examples/ 😄 |
|
@mbbarbosa Do you need one of us to split out the DynMatrix changes into their own PR? |
|
It is on my stack, but if you would like to pursue it independently, then I would appreciate the help. |
Cool. Let's communicate to avoid doing the work twice. I'll take the token for today. (But consider it released if nothing is pushed here by midnight.) |
f1f15a7 to
6d23357
Compare
|
I managed to fat-finger my way through this on my phone on the way in. Let's let CI run, but this is ready to merge as soon as that succeeds. I'll change my review to an accept. |
|
Thank you François |
Removed everything that depends on cost analysis.
This means that the theorem statements don't look so nice, because now one cannot use existential quantification over modules and all simulators are concrete.
Still, it is an interesting example of how UC execution model can look in EC.
I also touched the theories/algebra/DynMatrix.eca file due to smt instability.