Skip to content

Conversation

erral
Copy link
Contributor

@erral erral commented Sep 12, 2025

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR deprecates erral.erral-zcmlLanguageConfiguration. Plone Community has prepared a new extension that replaces this one and provides more features and will be publishing it.

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@filiptronicek
Copy link
Member

@erral to accept your code changes, I need two more things from you:

  1. Could you please rebase your changes to get rid of the merge conflict?
  2. Could you please sign the Eclipse Contributor Agreement by clicking on the link in the CI/checks of this PR? We require it for all contributions 🙏

@erral erral force-pushed the erral-deprecate-erral-zcml branch from c83f471 to 5c5198b Compare October 17, 2025 10:59
@erral
Copy link
Contributor Author

erral commented Oct 17, 2025

Done @filiptronicek !

@filiptronicek
Copy link
Member

Awesome @erral! Merging...

@filiptronicek filiptronicek merged commit 63e7539 into EclipseFdn:master Oct 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants