-
Notifications
You must be signed in to change notification settings - Fork 0
Md3 #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
To make branch merging easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the application from Angular Material Design 2 (M2) to Material Design 3 (M3), a significant theming and component API update. The migration involves updating dependencies, replacing M2 theming with M3's token-based system, and updating component APIs throughout the application.
Key Changes
- Dependency updates: Upgraded @Ecodev packages (fab-speed-dial, natural, natural-editor) from v20/v65 to v21/v66
- Theme system migration: Replaced M2 palette-based theming with M3 token-based theming using CSS custom properties (--mat-sys-*)
- Component API updates: Migrated button directives (mat-raised-button → matButton="filled"), typography classes (mat-headline-4 → mat-font-headline-lg), and color attributes (accent → tertiary, warn → error)
Reviewed changes
Copilot reviewed 128 out of 130 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json, yarn.lock | Updated @Ecodev dependencies to M3-compatible versions |
| client/styles/artisans.scss | New M3 theme configuration with design tokens |
| client/styles/_themes.scss, _components.scss, _rich-text.scss, _artisans.theme.scss | Removed M2 theme files and mixins |
| client/styles.scss | Added M3 theme initialization and CSS custom property usage |
| client/index.html | Simplified inline styles, moved to external CSS |
| client/styles/material_guides.scss | Removed M2 palette reference guide |
| Multiple component HTML files | Migrated typography classes, button directives, and color attributes throughout the application |
| Multiple component SCSS files | Replaced M2 theming mixins with M3 CSS custom properties |
| Multiple theme SCSS files | Removed component-specific M2 theme files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
client/app/shared/components/breadcrumbs/breadcrumbs.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 128 out of 130 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 128 out of 130 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 129 out of 131 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
And stop publishing on GitHub Packages because it does not provide any value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 129 out of 131 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Because why not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 129 out of 131 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Custom script `extract-material-icons` found 195/6410 (3%) icons probably used
No description provided.