splice: Don’t let users do unsigned splices #8052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddustin
force-pushed
the
ddustin/missing_user_sigs
branch
4 times, most recently
from
83c4632 to
3942d97
Compare
Contributor
|
Ack, looks good, but broke example generation and some tests? |
ddustin
force-pushed
the
ddustin/missing_user_sigs
branch
6 times, most recently
from
ab81c99 to
4bab93e
Compare
If a user tries to do a splice without signing their inputs we now provide them with a nice error message and cancel the RPC since that wouldn’t be productive for the user anyway. We also add a helpful message if they do the opposite — try to sign a PSBT where they did not add any inputs. Changelog-Changed: Update prevents users from trying to splice unsigned PSBTs — protecting against potential issues.
ddustin
force-pushed
the
ddustin/missing_user_sigs
branch
from
4bab93e to
13be8a2
Compare
Collaborator
Author
Turns out the way of detecting if taproot signatures exist in wally psbt is more complex and since the onchain wallet uses taproot now it caused a series of failures because it thought every splice wasn't signed. I updated to a new way of checking for taproot signatures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user tries to do a splice without signing their inputs we now provide them with a nice error message and cancel the RPC since that wouldn’t be productive for the user anyway.
We also add a helpful message if they do the opposite — try to sign a PSBT where they did not add any inputs.
Resolves #8011 and addresses
signpsbterror confusion here: #8030 (comment)