Add LSPS0 Client and Service Plugin #8227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't think the service does anything right now, so it's probably OK that it's enabled by default. But obviously we'll want some options and documentation once it does... |
Member
|
Very nice PR, looks like there is either a missing include of a Makefile or the Makefile was not committed, otherwise good to go 👍 ACK 80cb8c4 |
cdecker
approved these changes
Apr 25, 2025
nepet
force-pushed
the
2511-add-lsps0
branch
2 times, most recently
from
5794c12 to
9317921
Compare
Member
Author
|
@rustyrussell Added a bool option In a next iteration we could even go as far as to only build the lsps-service plugin when we enabled it during configuration as I guess that only a minority of nodes want to be LSPs anyways. This would safe us some time and space when compiling cln. |
nepet
force-pushed
the
2511-add-lsps0
branch
2 times, most recently
from
44e0488 to
3a6eed9
Compare
Signed-off-by: Peter Neuroth <[email protected]>
Adds an async safe JSON-RPC V2 client for a generic transport layer. The transport layer we will use later on are BOLT8 lightning messages. Signed-off-by: Peter Neuroth <[email protected]>
For lsps0 we send JSON-RPC messages via custom messages over the lightning network. This commit adds a basic implementation based on custom messages.
We want a working client to run some integration tests. Changelog-Added: lsps-plugin: lsps0 client support
Implements the LSPS0 service plugin for core lightning Changelog-Added: lsps-plugin: lsps0 service support Signed-off-by: Peter Neuroth <[email protected]>
Signed-off-by: Peter Neuroth <[email protected]>
Adds some additional documentation to the json-rpc v2.0 messages and error types. Signed-off-by: Peter Neuroth <[email protected]>
ShahanaFarooqui
merged commit ae226cb
into
ElementsProject:master
37 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implments the basic transport mechanism (
lsps0) for LSP clients and services as described in https://github.com/lightning/blips/blob/master/blip-0050.mdlsps0describes how LSPs communicate with their clients, wich basically is JSON-RPC v2.0 via custom lightning messages.