Skip to content

Conversation

@sc0ttdav3y
Copy link

@sc0ttdav3y sc0ttdav3y commented Sep 24, 2024

This PR incorporates the work in #48, and adds additional properties to fix the deprecation notices since PHP 8.3:

[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadHeader is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:87
[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tdSubstitute is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:96
[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadBody is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:98

I have not been able to test via the included tests, as PHPUnit is still at v4 and this is no longer compatible with PHP 8.3 (and I don't have the time to upgrade it in this PR), however this is a minimal change so it should not have any new bugs.

@bradlocking
Copy link

Hi - is this planned to be merged soon? i'm getting the same error upgrading to php 8.3

@tzi
Copy link
Member

tzi commented Jun 5, 2025

I can work on it next week. Thanks for your help <3

@u01jmg3
Copy link

u01jmg3 commented Oct 23, 2025

@tzi: how did you get on? Would be good to get this added to a new release 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants